See bug 25498. Would be helpful to send a notice to inform the new owner of this change.
Created attachment 168970 [details] [review] Bug 30955: Sends notice to new owner at transfer This patch adds a new notice, TRANSFER_OWNERSHIP, under a new module, Lists. When a list is transferred to a new owner, this notice is triggered, containing a short paragraph detailing the list name. TO TEST: a) log in as a koha superlibrarian b) go to the lists module, create a public list, and make a note of the title used c) on the lists module, transfer the list to some other user, and make a note of the user used d) go to the patron notices page for the user in step c e) ensure that a notice has been generated 1) check the contents of the notice, it should contain - the new owner's name - the list's title - the old owner's name & (if set) email f) under tools > notices, modify the notice for TRANSFER_OWNERSHIP g) repeat steps c-e 1) ensure the modifications you've made are now visible in the notice
Thanks in advance for a sign-off :-) Jake
Created attachment 169252 [details] [review] Bug 30955: Sends notice to new owner at transfer This patch adds a new notice, TRANSFER_OWNERSHIP, under a new module, Lists. When a list is transferred to a new owner, this notice is triggered, containing a short paragraph detailing the list name. TO TEST: a) log in as a koha superlibrarian b) go to the lists module, create a public list, and make a note of the title used c) on the lists module, transfer the list to some other user, and make a note of the user used d) go to the patron notices page for the user in step c e) ensure that a notice has been generated 1) check the contents of the notice, it should contain - the new owner's name - the list's title - the old owner's name & (if set) email f) under tools > notices, modify the notice for TRANSFER_OWNERSHIP g) repeat steps c-e 1) ensure the modifications you've made are now visible in the notice Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> QA script unhappy: FAIL installer/data/mysql/atomicupdate/bug_30955-add-new-notice.pl FAIL forbidden patterns forbidden pattern: tab char (line 1) WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 13) WARN t/db_dependent/Koha/Virtualshelf.t WARN tidiness The file is less tidy than before (bad/messy lines before: 9, now: 12)
Created attachment 169267 [details] [review] Bug 30955: Sends notice to new owner at transfer This patch adds a new notice, TRANSFER_OWNERSHIP, under a new module, Lists. When a list is transferred to a new owner, this notice is triggered, containing a short paragraph detailing the list name. TO TEST: a) log in as a koha superlibrarian b) go to the lists module, create a public list, and make a note of the title used c) on the lists module, transfer the list to some other user, and make a note of the user used d) go to the patron notices page for the user in step c e) ensure that a notice has been generated 1) check the contents of the notice, it should contain - the new owner's name - the list's title - the old owner's name & (if set) email f) under tools > notices, modify the notice for TRANSFER_OWNERSHIP g) repeat steps c-e 1) ensure the modifications you've made are now visible in the notice Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Yes, it was a bit ugly, apologies! Fixed now :-)
Created attachment 170748 [details] [review] Bug 30955: Sends notice to new owner at transfer This patch adds a new notice, TRANSFER_OWNERSHIP, under a new module, Lists. When a list is transferred to a new owner, this notice is triggered, containing a short paragraph detailing the list name. TO TEST: a) log in as a koha superlibrarian b) go to the lists module, create a public list, and make a note of the title used c) on the lists module, transfer the list to some other user, and make a note of the user used d) go to the patron notices page for the user in step c e) ensure that a notice has been generated 1) check the contents of the notice, it should contain - the new owner's name - the list's title - the old owner's name & (if set) email f) under tools > notices, modify the notice for TRANSFER_OWNERSHIP g) repeat steps c-e 1) ensure the modifications you've made are now visible in the notice Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Rebased atop the Bootstrap5 changes. As this only includes a 22-character change on one line, and the change is purely cosmetic, I have left the sign-off line in. Please feel free to revert this status if this was not the right thing to do. Jake.
Nice, Jake. I was wondering if we need a mechanism for turning this off. I can just delete the notice. Right now this would just start sending TRANSFER_OWNERSHIP notices when libraries upgraded. Should we have an on/off switch that libraries have to turn on?
Hey Lucas, I suppose we have three options, here: a) don't include a notice out of the box, and let libraries figure out the new notice exists b) add a syspref for this (yet another syspref?) c) include the notice, let the notices fly, and propose we won't upset anyone Happy to go with any of these, though a syspref does seem a bit bonkers for this? Jake.
(In reply to Jake Deery from comment #9) > Hey Lucas, > > I suppose we have three options, here: > a) don't include a notice out of the box, and let libraries figure out the > new notice exists > b) add a syspref for this (yet another syspref?) > c) include the notice, let the notices fly, and propose we won't upset > anyone > > Happy to go with any of these, though a syspref does seem a bit bonkers for > this? > > Jake. Jake, I agree with you. Sys pref is bonkers. I think, in this case we should include the notice and let em fly. Which I think means all is well here, no additional work needed.
Created attachment 170826 [details] [review] Bug 30955: Sends notice to new owner at transfer This patch adds a new notice, TRANSFER_OWNERSHIP, under a new module, Lists. When a list is transferred to a new owner, this notice is triggered, containing a short paragraph detailing the list name. TO TEST: a) log in as a koha superlibrarian b) go to the lists module, create a public list, and make a note of the title used c) on the lists module, transfer the list to some other user, and make a note of the user used d) go to the patron notices page for the user in step c e) ensure that a notice has been generated 1) check the contents of the notice, it should contain - the new owner's name - the list's title - the old owner's name & (if set) email f) under tools > notices, modify the notice for TRANSFER_OWNERSHIP g) repeat steps c-e 1) ensure the modifications you've made are now visible in the notice Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Wicked, thanks for your time Lucas! Jake.
Some hopefully smaller stuff here: 1) This patch introduces a new notice category: Lists. I think this is a good idea, but right now this will only contain one notice, wihle the other list related ones are still under OPAC, creating an inconsistency. I see 2 options: * Add the new category on a separate bug and then move all the notices into it at the same time * Move them here, notices are: LIST, SHARE_INVITE, SHARE_ACCEPT 2) The big question: add notice on update or not. I just pushed another bug recently that decided to not add on update. I think we could probably argue for both. But maybe we should try to have some guideline/consistency here? Bug 36915 - Send email notification when a booking is cancelled Don't add on update * Least surprise, no behavior change * Libraries will not miss to translate/adapt the notice text to local guidelines Add on update * Libraries can see how the notice looks like. But: bug 36815 will help with that now. I am leaning towards removing the database update right now. But happy to discus and be persuaded.
Hi Katrin, Agree on point 1) – I can create a new bug for this shortly. On point 2) – I am happy to go with removing the database update, but it raises a question for me: should we have a repository of default notices for libraries to refer to? Jake.
(In reply to Jake Deery from comment #14) > Hi Katrin, > > Agree on point 1) – I can create a new bug for this shortly. > > On point 2) – I am happy to go with removing the database update, but it > raises a question for me: should we have a repository of default notices for > libraries to refer to? > > Jake. We have had them on the wiki so far, but with Martin's new feature, one should be able to get the sample notice content once the notice with the right code has been created: bug 36815
Interesting! Let's drop that databsae update, then. As there is a way of 'getting the default' now, its easy for librarians to get the notice working quickly :-) Jake.
Created attachment 172443 [details] [review] Bug 30955: (follow-up) Remove database update
Gone! Jake.
Would you mind squashing them? :)
Created attachment 172445 [details] [review] Bug 30955: Sends notice to new owner at transfer This patch adds a new notice, TRANSFER_OWNERSHIP, under a new module, Lists. When a list is transferred to a new owner, this notice is triggered, containing a short paragraph detailing the list name. TO TEST: a) log in as a koha superlibrarian b) go to the lists module, create a public list, and make a note of the title used c) on the lists module, transfer the list to some other user, and make a note of the user used d) go to the patron notices page for the user in step c e) ensure that a notice has been generated 1) check the contents of the notice, it should contain - the new owner's name - the list's title - the old owner's name & (if set) email f) under tools > notices, modify the notice for TRANSFER_OWNERSHIP g) repeat steps c-e 1) ensure the modifications you've made are now visible in the notice Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Done..! :-) Jake.
Created attachment 173213 [details] [review] Bug 30955: Sends notice to new owner at transfer This patch adds a new notice, TRANSFER_OWNERSHIP, under a new module, Lists. When a list is transferred to a new owner, this notice is triggered, containing a short paragraph detailing the list name. TO TEST: a) log in as a koha superlibrarian b) go to the lists module, create a public list, and make a note of the title used c) on the lists module, transfer the list to some other user, and make a note of the user used d) go to the patron notices page for the user in step c e) ensure that a notice has been generated 1) check the contents of the notice, it should contain - the new owner's name - the list's title - the old owner's name & (if set) email f) under tools > notices, modify the notice for TRANSFER_OWNERSHIP g) repeat steps c-e 1) ensure the modifications you've made are now visible in the notice Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 173214 [details] [review] Bug 30955: (QA follow-up) Reduce database hits and clarify notice This patch updates the library selection from using the new owners home library to using the current sessions library in keeping with the direction of travel in other bugs of this type in Koha currently. We also update the default notice text to clarify who sent the notice vs who previously owned the list. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 173215 [details] [review] Bug 30955: Sends notice to new owner at transfer This patch adds a new notice, TRANSFER_OWNERSHIP, under a new module, Lists. When a list is transferred to a new owner, this notice is triggered, containing a short paragraph detailing the list name. TO TEST: a) log in as a koha superlibrarian b) go to the lists module, create a public list, and make a note of the title used c) on the lists module, transfer the list to some other user, and make a note of the user used d) go to the patron notices page for the user in step c e) ensure that a notice has been generated 1) check the contents of the notice, it should contain - the new owner's name - the list's title - the old owner's name & (if set) email f) under tools > notices, modify the notice for TRANSFER_OWNERSHIP g) repeat steps c-e 1) ensure the modifications you've made are now visible in the notice Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 173216 [details] [review] Bug 30955: (QA follow-up) Reduce database hits and clarify notice This patch updates the library selection from using the new owners home library to using the current sessions library in keeping with the direction of travel in other bugs of this type in Koha currently. We also update the default notice text to clarify who sent the notice vs who previously owned the list. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
1) Follow-up bug or patch (In reply to Katrin Fischer from comment #13) > Some hopefully smaller stuff here: > > 1) This patch introduces a new notice category: Lists. > > I think this is a good idea, but right now this will only contain one > notice, wihle the other list related ones are still under OPAC, creating an > inconsistency. I see 2 options: > > * Add the new category on a separate bug and then move all the notices into > it at the same time > * Move them here, notices are: LIST, SHARE_INVITE, SHARE_ACCEPT (In reply to Jake Deery from comment #14) > Agree on point 1) – I can create a new bug for this shortly. Can you please do that? I think we should do this for 24.11 to have a consistent state. It should be an easy database update to move these notices. 2) Is this authorship line correct? From: PerplexedTheta <jahdobble@llownd.net> Waiting for 2).
Created attachment 173254 [details] [review] Bug 30955: (follow-up) Merged related notices into lists This patch merges the SHARE_ACCEPT and SHARE_INVITE notices into the lists module. This makes a clearer case for introducing the lists module in the first place.
Let me know if you want those squashing once you've had a look :-) Jake.
Oh, and, I think we had this problem before with the author line. It was because I was pushing a few patches from my other laptop :/ Can we update the mailmap to solve this, or can I change this some other way? Jake.
(In reply to Jake Deery from comment #29) > Oh, and, I think we had this problem before with the author line. It was > because I was pushing a few patches from my other laptop :/ > > Can we update the mailmap to solve this, or can I change this some other way? > > Jake. You can change the author-line in git. I think it's something like git commit --amend --author (to use your current config). Otherwise please check docs :) It's not pushed yet, so that's why I was waiting.
Created attachment 173255 [details] [review] Bug 30955: Sends notice to new owner at transfer This patch adds a new notice, TRANSFER_OWNERSHIP, under a new module, Lists. When a list is transferred to a new owner, this notice is triggered, containing a short paragraph detailing the list name. TO TEST: a) log in as a koha superlibrarian b) go to the lists module, create a public list, and make a note of the title used c) on the lists module, transfer the list to some other user, and make a note of the user used d) go to the patron notices page for the user in step c e) ensure that a notice has been generated 1) check the contents of the notice, it should contain - the new owner's name - the list's title - the old owner's name & (if set) email f) under tools > notices, modify the notice for TRANSFER_OWNERSHIP g) repeat steps c-e 1) ensure the modifications you've made are now visible in the notice Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Thanks for the advice, cait – all sorted :-) Jake.
Sequence of patches got a bit messed up. When reattaching, please always reattach all patches! Will fix with git bz apply -i
Thanks cait, another one to remember for the future :-) Jake.
Pushed for 24.11! Well done everyone, thank you!
Enhancement, no 24.05.x backport