In translation, the sentence below is broken into 2 parts by the link. This makes it hard to translate as you can't move around words easily before and after the link for good grammar and are missing context: <span>Add values to the <a href="/cgi-bin/koha/admin/authorised_values.pl?searchfield=UPLOAD">UPLOAD authorized value category</a> otherwise all uploads will be marked as temporary.</span>
Created attachment 145114 [details] [review] Bug 30993: Improve translatabilty of UPLOAD av hint Improve translatability on the hint for AV UPLOAD on the upload tool page. To test: * Go to tools > uploads * Verify that the hint below the 'Browse...' displayes nicely and the link to the UPLOAD AV works correctly * Apply patch * Verify the link still works and the sentence reads correctly. NOTE: now only UPLOAD will be linked. If you are familiar with the process, you can also make sure the strings now show up on po files as expected: https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_in_your_installation
Needs a little more tweaking.
Created attachment 145166 [details] [review] Bug 30993: Improve translatabilty of UPLOAD av hint Improve translatability on the hint for AV UPLOAD on the upload tool page. To test: * Go to tools > uploads * Verify that the hint below the 'Browse...' displayes nicely and the link to the UPLOAD AV works correctly * Apply patch * Verify the link still works and the sentence reads correctly. NOTE: now only UPLOAD will be linked. If you are familiar with the process, you can also make sure the strings now show up on po files as expected: https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_in_your_installation
Created attachment 145168 [details] [review] Bug 30993: Improve translatabilty of UPLOAD av hint Improve translatability on the hint for AV UPLOAD on the upload tool page. To test: * Go to tools > uploads * Verify that the hint below the 'Browse...' displayes nicely and the link to the UPLOAD AV works correctly * Apply patch * Verify the link still works and the sentence reads correctly. NOTE: now only UPLOAD will be linked. If you are familiar with the process, you can also make sure the strings now show up on po files as expected: https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_in_your_installation Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Hi :) It works! code: I think KohaSpan isn't needed for a block containing an <a>. It just adds a <span> that has not purpose for string extraction given the <a>. But I see Bug 29602 uses it all of them except for on occurrence that has no filter. https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133381 But I used the raw filter when making Bug 30733 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136286 So maybe actually KohaSpan is needed or cleaner?
Created attachment 146515 [details] [review] Bug 30993: Improve translatabilty of UPLOAD av hint Improve translatability on the hint for AV UPLOAD on the upload tool page. To test: * Go to tools > uploads * Verify that the hint below the 'Browse...' displayes nicely and the link to the UPLOAD AV works correctly * Apply patch * Verify the link still works and the sentence reads correctly. NOTE: now only UPLOAD will be linked. If you are familiar with the process, you can also make sure the strings now show up on po files as expected: https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_in_your_installation Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 146687 [details] [review] Bug 30993: (QA follow-up) Add missing filter Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to 22.11.x for next release
Backported to 22.05.x for upcoming 22.05.11
applied to 21.11.x for 21.11.19