Bug 30993 - Translation: Unbreak sentence in upload.tt
Summary: Translation: Unbreak sentence in upload.tt
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: Katrin Fischer
QA Contact: Kyle M Hall
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-18 11:17 UTC by Katrin Fischer
Modified: 2023-12-28 20:43 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.03,22.05.11, 21.11.19


Attachments
Bug 30993: Improve translatabilty of UPLOAD av hint (2.06 KB, patch)
2023-01-06 23:12 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 30993: Improve translatabilty of UPLOAD av hint (2.26 KB, patch)
2023-01-09 21:19 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 30993: Improve translatabilty of UPLOAD av hint (2.33 KB, patch)
2023-01-09 21:47 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 30993: Improve translatabilty of UPLOAD av hint (2.39 KB, patch)
2023-02-10 19:34 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 30993: (QA follow-up) Add missing filter (1.51 KB, patch)
2023-02-15 12:29 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-06-18 11:17:37 UTC
In translation, the sentence below is broken into 2 parts by the link. This makes it hard to translate as you can't move around words easily before and after the link for good grammar and are missing context:

<span>Add values to the <a href="/cgi-bin/koha/admin/authorised_values.pl?searchfield=UPLOAD">UPLOAD authorized value category</a> otherwise all uploads will be marked as temporary.</span>
Comment 1 Katrin Fischer 2023-01-06 23:12:32 UTC
Created attachment 145114 [details] [review]
Bug 30993: Improve translatabilty of UPLOAD av hint

Improve translatability on the hint for AV UPLOAD
on the upload tool page.

To test:
* Go to tools > uploads
* Verify that the hint below the 'Browse...' displayes nicely
  and the link to the UPLOAD AV works correctly
* Apply patch
* Verify the link still works and the sentence reads correctly.
  NOTE: now only UPLOAD will be linked.

If you are familiar with the process, you can also make sure
the strings now show up on po files as expected:
https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_in_your_installation
Comment 2 Katrin Fischer 2023-01-09 21:06:50 UTC
Needs a little more tweaking.
Comment 3 Katrin Fischer 2023-01-09 21:19:25 UTC
Created attachment 145166 [details] [review]
Bug 30993: Improve translatabilty of UPLOAD av hint

Improve translatability on the hint for AV UPLOAD
on the upload tool page.

To test:
* Go to tools > uploads
* Verify that the hint below the 'Browse...' displayes nicely
  and the link to the UPLOAD AV works correctly
* Apply patch
* Verify the link still works and the sentence reads correctly.
  NOTE: now only UPLOAD will be linked.

If you are familiar with the process, you can also make sure
the strings now show up on po files as expected:
https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_in_your_installation
Comment 4 Caroline Cyr La Rose 2023-01-09 21:47:30 UTC
Created attachment 145168 [details] [review]
Bug 30993: Improve translatabilty of UPLOAD av hint

Improve translatability on the hint for AV UPLOAD
on the upload tool page.

To test:
* Go to tools > uploads
* Verify that the hint below the 'Browse...' displayes nicely
  and the link to the UPLOAD AV works correctly
* Apply patch
* Verify the link still works and the sentence reads correctly.
  NOTE: now only UPLOAD will be linked.

If you are familiar with the process, you can also make sure
the strings now show up on po files as expected:
https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_in_your_installation

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 5 Victor Grousset/tuxayo 2023-01-10 05:36:11 UTC
Hi :) It works!

code: I think KohaSpan isn't needed for a block containing an <a>. It just adds a <span> that has not purpose for string extraction given the <a>.

But I see Bug 29602 uses it all of them except for on occurrence that has no filter.
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133381

But I used the raw filter when making Bug 30733
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136286

So maybe actually KohaSpan is needed or cleaner?
Comment 6 Kyle M Hall 2023-02-10 19:34:24 UTC
Created attachment 146515 [details] [review]
Bug 30993: Improve translatabilty of UPLOAD av hint

Improve translatability on the hint for AV UPLOAD
on the upload tool page.

To test:
* Go to tools > uploads
* Verify that the hint below the 'Browse...' displayes nicely
  and the link to the UPLOAD AV works correctly
* Apply patch
* Verify the link still works and the sentence reads correctly.
  NOTE: now only UPLOAD will be linked.

If you are familiar with the process, you can also make sure
the strings now show up on po files as expected:
https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_in_your_installation

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 7 Tomás Cohen Arazi 2023-02-15 12:29:20 UTC
Created attachment 146687 [details] [review]
Bug 30993: (QA follow-up) Add missing filter

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 8 Tomás Cohen Arazi 2023-02-15 12:34:27 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 9 Pedro Amorim 2023-02-16 10:40:05 UTC
Nice work everyone!

Pushed to 22.11.x for next release
Comment 10 Lucas Gass 2023-03-01 13:50:41 UTC
Backported to 22.05.x for upcoming 22.05.11
Comment 11 Arthur Suzuki 2023-03-29 08:04:05 UTC
applied to 21.11.x for 21.11.19
Comment 12 wainuiwitikapark 2023-04-27 03:51:17 UTC
Not backported to 21.05.x