Currently, all cash management summations are bound to the CASH payment type, but SIP2 devices can also take Cash payments and record them as SIP00. Cash management should be updated to use 'CASH' OR 'SIP00' wherever we currently limit to 'CASH'.
Created attachment 136476 [details] [review] Bug 31036: Treat SIP00 that same as CASH SIP00 is the code for CASH transactions that have taken place on a SIP client. Cash management treats CASH type transactions as a special case for banking and register requirements. This patch brings SIP00 in line with the CASH handling code of cash management.
Created attachment 136477 [details] [review] Bug 31036: Treat SIP00 that same as CASH SIP00 is the code for CASH transactions that have taken place on a SIP client. Cash management treats CASH type transactions as a special case for banking and register requirements. This patch brings SIP00 in line with the CASH handling code of cash management. Test plan 1) Enable cash management with 'EnablePointOfSale' 2) Enable cash registers with 'UseCashRegisters' 3) Add a cash register via 'Administration > Cash registers' 4) Make some payments against the ash register in the staff client 5) Attempt to make a payment via a SIP client without having associated a cash register to the SIP account config 5a) This should now fail 6) Attach the cash register to the SIP account used above 6a) Payment should now work again on SIP transactions 7) Look at the cash register details page for the cash register 7a) 'Bankale' should now include cash from both SIP and Staff client sales
Created attachment 137431 [details] [review] Bug 31036: Treat SIP00 that same as CASH SIP00 is the code for CASH transactions that have taken place on a SIP client. Cash management treats CASH type transactions as a special case for banking and register requirements. This patch brings SIP00 in line with the CASH handling code of cash management. Test plan 1) Enable cash management with 'EnablePointOfSale' 2) Enable cash registers with 'UseCashRegisters' 3) Add a cash register via 'Administration > Cash registers' 4) Make some payments against the ash register in the staff client 5) Attempt to make a payment via a SIP client without having associated a cash register to the SIP account config 5a) This should now fail 6) Attach the cash register to the SIP account used above 6a) Payment should now work again on SIP transactions 7) Look at the cash register details page for the cash register 7a) 'Bankale' should now include cash from both SIP and Staff client sales Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
This has been deployed for a while now.. signing off
Created attachment 137757 [details] [review] Bug 31036: Treat SIP00 that same as CASH SIP00 is the code for CASH transactions that have taken place on a SIP client. Cash management treats CASH type transactions as a special case for banking and register requirements. This patch brings SIP00 in line with the CASH handling code of cash management. Test plan 1) Enable cash management with 'EnablePointOfSale' 2) Enable cash registers with 'UseCashRegisters' 3) Add a cash register via 'Administration > Cash registers' 4) Make some payments against the ash register in the staff client 5) Attempt to make a payment via a SIP client without having associated a cash register to the SIP account config 5a) This should now fail 6) Attach the cash register to the SIP account used above 6a) Payment should now work again on SIP transactions 7) Look at the cash register details page for the cash register 7a) 'Bankale' should now include cash from both SIP and Staff client sales Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
> 5) Attempt to make a payment via a SIP client without having associated > a cash register to the SIP account config > 5a) This should now fail I think this would warrant a 'bold' note in the release notes as it has the potential to break self checks unexpectedly. Could it be an option to make it fail gracefully/with a good error message?
It's a fair point.. I struggled to come up with a solution.. either a big bold warning next to the system preference that enables cash registers.. or perhaps a soft fallback to the first register we find on the system in SIP if there isn't one in the sip config.. Or.. both.. I feel like the soft fallback could lead to unexpected results at cashup too. Any preference?
I think the soft fallback is potentially more dangerous, so the note would be better. And I think this should probably not be backported.
Created attachment 137762 [details] [review] Bug 31036: (QA follow-up) Add a warning to the system preference As suggested by Katrin, adding a warning to the system preference that this has an effect on SIP configurations that needs to be understood. https://bugs.koha-community.org/show_bug.cgi?id=31063
Created attachment 137763 [details] [review] Bug 31036: (QA follow-up) Add a warning to the system preference As suggested by Katrin, adding a warning to the system preference that this has an effect on SIP configurations that needs to be understood.
Added text for release notes and added a warning to the system preference in a QA follow-up as discussed :)
Pushed to master for 22.11. Nice work everyone, thanks!
Backported to 22.05.x for 22.05.05
thx pushed to 21.11.x for 21.11.12
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved.