In bug 29495 we added a follow-up to fix the TestBuilder test. However, we added the change to the wrong place; Instead of forcing undefined in the test data and not creating a link, we should add the field lacking a proper foreign key to the list in _should_be_fk These are deliberately not foreign keys because they link to one of two tables.. the original and old_ version tables.. but we do add dbix::class relations for the link.
Created attachment 137216 [details] [review] Bug 31110: Move 'ReturnClaim.issue_id' to _should_be_fk This patch moves the issue_id field definition for ReturnClaim in TestBuilder to the list of 'fake' keys in _should_be_fk. Test plan 1) Run t/db_dependent/TestBuilder.t before applying the patch 2) Run t/db_dependent/TestBuilder.t after applying the patch 3) Signoff if the test passes both times.
It doesn't apply on master, and when fixing it I get the error for CheckoutRenewal back!
Weird.. it passed before we made the same change for CheckoutRenewals.. seems we can't add the same thing twice. We can certainly leave this one as is for now..