We don't need our own JS functions to parse date, we can rely on dayjs for that.
Created attachment 137680 [details] [review] Bug 31149: Use dayjs to parse dates We can use the isValid's dayjs function instead of our own parsing functions. Test plan: Confirm that you cannot enter an invalid date when using a date picker widget.
Created attachment 144680 [details] [review] Bug 31149: Use dayjs to parse dates We can use the isValid's dayjs function instead of our own parsing functions. Test plan: Confirm that you cannot enter an invalid date when using a date picker widget. Works as expected. Signed-off-by: LMSCloudPaulD <paul.derscheid@lmscloud.de>
Created attachment 144733 [details] [review] Bug 31149: Use dayjs to parse dates We can use the isValid's dayjs function instead of our own parsing functions. Test plan: Confirm that you cannot enter an invalid date when using a date picker widget. Works as expected. Signed-off-by: LMSCloudPaulD <paul.derscheid@lmscloud.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This would be a PQA from me.. but we're blocked so marking as such.