Bug 31149 - Use dayjs to parse dates
Summary: Use dayjs to parse dates
Status: BLOCKED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on: 30310
Blocks:
  Show dependency treegraph
 
Reported: 2022-07-13 07:04 UTC by Jonathan Druart
Modified: 2022-12-20 12:56 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 31149: Use dayjs to parse dates (3.67 KB, patch)
2022-07-13 07:08 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 31149: Use dayjs to parse dates (3.76 KB, patch)
2022-12-16 14:13 UTC, Paul Derscheid
Details | Diff | Splinter Review
Bug 31149: Use dayjs to parse dates (3.81 KB, patch)
2022-12-20 12:56 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2022-07-13 07:04:42 UTC
We don't need our own JS functions to parse date, we can rely on dayjs for that.
Comment 1 Jonathan Druart 2022-07-13 07:08:18 UTC
Created attachment 137680 [details] [review]
Bug 31149: Use dayjs to parse dates

We can use the isValid's dayjs function instead of our own parsing
functions.

Test plan:
Confirm that you cannot enter an invalid date when using a date picker widget.
Comment 2 Paul Derscheid 2022-12-16 14:13:20 UTC
Created attachment 144680 [details] [review]
Bug 31149: Use dayjs to parse dates

We can use the isValid's dayjs function instead of our own parsing
functions.

Test plan:
Confirm that you cannot enter an invalid date when using a date picker widget.

Works as expected.

Signed-off-by: LMSCloudPaulD <paul.derscheid@lmscloud.de>
Comment 3 Martin Renvoize 2022-12-20 12:56:06 UTC
Created attachment 144733 [details] [review]
Bug 31149: Use dayjs to parse dates

We can use the isValid's dayjs function instead of our own parsing
functions.

Test plan:
Confirm that you cannot enter an invalid date when using a date picker widget.

Works as expected.

Signed-off-by: LMSCloudPaulD <paul.derscheid@lmscloud.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2022-12-20 12:56:49 UTC
This would be a PQA from me.. but we're blocked so marking as such.