On the suggestions home page I expanded the "Suggestions information" sidebar filter, then entered dates in the "Suggested date from:" and "To:" fields. When I submit I get an error: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'suggesteddate_from' in 'where clause' at /kohadevbox/koha/Koha/Objects.pm line 394 at /usr/share/perl5/DBIx/Class/Exception.pm line 77
Confirmed! It cannot work, the column in the database is suggesteddate. But this problem exists for all the data range searches in the form.
Created attachment 138436 [details] [review] Bug 31158: (bug 23991 follow-up) Fix suggestion search by dates Search suggestions by date is broken, we don't remove the '_from' CGI params for the DBIC query DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'suggesteddate_from' in 'where clause' at /kohadevbox/koha/Koha/Objects.pm line 394 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 Test plan: Create some suggestions, search for them using date range (suggested date, managed date and accepted date)
Created attachment 138519 [details] [review] Bug 30879: DBRev 22.06.00.031 Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Rachael Laritz <rachael.laritz@inlibro.com>
Rachael, were you signed off on purpose? The process you followed is not correct, please read https://wiki.koha-community.org/wiki/Sign_off_on_patches You didn't attach the correct patch to the bug report.
Created attachment 138762 [details] [review] Bug 31158: (bug 23991 follow-up) Fix suggestion search by dates Search suggestions by date is broken, we don't remove the '_from' CGI params for the DBIC query DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'suggesteddate_from' in 'where clause' at /kohadevbox/koha/Koha/Objects.pm line 394 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 Test plan: Create some suggestions, search for them using date range (suggested date, managed date and accepted date) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 138930 [details] [review] Bug 31158: (bug 23991 follow-up) Fix suggestion search by dates Search suggestions by date is broken, we don't remove the '_from' CGI params for the DBIC query DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'suggesteddate_from' in 'where clause' at /kohadevbox/koha/Koha/Objects.pm line 394 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 Test plan: Create some suggestions, search for them using date range (suggested date, managed date and accepted date) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Solid fix, works as expected.. Passing QA
*** Bug 31347 has been marked as a duplicate of this bug. ***
Pushed to master for 22.11. Nice work everyone, thanks!
This shouldn't be needed in 22.05.x, no backport