Bug 31167 - Only mark due dates in the past red on overdues report
Summary: Only mark due dates in the past red on overdues report
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Emily Lamancusa (emlam)
URL:
Keywords:
Depends on: 27996
Blocks:
  Show dependency treegraph
 
Reported: 2022-07-15 19:07 UTC by Katrin Fischer
Modified: 2025-03-21 16:51 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the overdues report (Circulation > Overdues > Overdues) so that when the "Show any items currently checked out" filter is selected, the due date is only shown in red for overdue items. Currently, the due date is in red for all items.
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 31167: Only mark due dates in the past red on overdues report (4.49 KB, patch)
2025-03-17 15:58 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31167: Only mark due dates in the past red on overdues report (4.54 KB, patch)
2025-03-18 01:44 UTC, David Nind
Details | Diff | Splinter Review
Bug 31167: Only mark due dates in the past red on overdues report (4.61 KB, patch)
2025-03-20 17:52 UTC, Emily Lamancusa (emlam)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-07-15 19:07:36 UTC
Bug 27996 added formatting to the due dates on the overdues report, but we forgt that it doesn't only show due dates in the past. If you check the checkbox on top, also current checkouts with due dates in the future will display. They area also formatted in red now.
Comment 1 Caroline Cyr La Rose 2023-04-21 14:50:06 UTC
I confirm this is still valid
Comment 2 Gretchen Maxeiner 2025-03-11 17:23:10 UTC
We would be interested in this fix. This report is quick and easy to use to get at all the items that are out, but the false red for items due in future makes it too confusing to really advertise to staff.
Comment 3 Owen Leonard 2025-03-17 15:58:51 UTC
Created attachment 179414 [details] [review]
Bug 31167: Only mark due dates in the past red on overdues report

This patch adds information about whether an entry in the overdue report
is overdue so we can style dates accordingly. We can't assume that each
result is overdue because the report can be changed to include all
checked out items.

To test, apply the patch and go to Circulation.

- Check out to a patron.
- Use the "Specify due date" option to check out some items with due
  dates in the past, due dates today, and due dates in the future.
- Go to Circulation -> Overdues.
- You should see the items which have due dates in the past. The date in
  the "Due date" column should be red text. The "Checked out on" date
  should be regular text.
- In the sidebar, check the "Show any items currently checked out"
  checkbox and submit the form.
- You should now see all the items you just checked out. Only the
  overdue items should show their due date in red.

Sponsored-by: Athens County Public Libraries
Comment 4 David Nind 2025-03-18 01:44:11 UTC
Created attachment 179418 [details] [review]
Bug 31167: Only mark due dates in the past red on overdues report

This patch adds information about whether an entry in the overdue report
is overdue so we can style dates accordingly. We can't assume that each
result is overdue because the report can be changed to include all
checked out items.

To test, apply the patch and go to Circulation.

- Check out to a patron.
- Use the "Specify due date" option to check out some items with due
  dates in the past, due dates today, and due dates in the future.
- Go to Circulation -> Overdues.
- You should see the items which have due dates in the past. The date in
  the "Due date" column should be red text. The "Checked out on" date
  should be regular text.
- In the sidebar, check the "Show any items currently checked out"
  checkbox and submit the form.
- You should now see all the items you just checked out. Only the
  overdue items should show their due date in red.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Emily Lamancusa (emlam) 2025-03-20 17:52:46 UTC
Created attachment 179562 [details] [review]
Bug 31167: Only mark due dates in the past red on overdues report

This patch adds information about whether an entry in the overdue report
is overdue so we can style dates accordingly. We can't assume that each
result is overdue because the report can be changed to include all
checked out items.

To test, apply the patch and go to Circulation.

- Check out to a patron.
- Use the "Specify due date" option to check out some items with due
  dates in the past, due dates today, and due dates in the future.
- Go to Circulation -> Overdues.
- You should see the items which have due dates in the past. The date in
  the "Due date" column should be red text. The "Checked out on" date
  should be regular text.
- In the sidebar, check the "Show any items currently checked out"
  checkbox and submit the form.
- You should now see all the items you just checked out. Only the
  overdue items should show their due date in red.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 6 Katrin Fischer 2025-03-21 16:51:10 UTC
Pushed for 25.05!

Well done everyone, thank you!