Koha_Master/2115 19:52:29 koha_1 | # Failed test 'No tests run for subtest "PseudonymizedBorrowerAttributes tests"' 19:52:29 koha_1 | # at t/db_dependent/Koha/Pseudonymization.t line 211. 19:52:29 koha_1 | Duplicate ID# Looks like your test exited with 255 just after 3.
Created attachment 137938 [details] [review] Bug 31201: Prevent Pseudonymization.t to fail It's failing if selenium/patrons_search.t failed before, they are using the same code and the selenium tests didn't clean correctly
It is actually failing randomly, with this patch at least: $ prove t/db_dependent/Koha/Pseudonymization.t t/db_dependent/Koha/Pseudonymization.t .. 1/3 # Failed test 'Attribute 1 should be retrieved correctly' # at t/db_dependent/Koha/Pseudonymization.t line 201. # Structures begin differing at: # $got->{code} = 'sJHyWk' # $expected->{code} = 'YgXf22O9Vp' # Failed test 'Attribute 2 should be retrieved correctly' # at t/db_dependent/Koha/Pseudonymization.t line 207. # Structures begin differing at: # $got->{attribute} = 'attribute for code1' # $expected->{attribute} = 'attribute for code3' # Looks like you failed 2 tests of 3. t/db_dependent/Koha/Pseudonymization.t .. 3/3 # Failed test 'PseudonymizedBorrowerAttributes tests' # at t/db_dependent/Koha/Pseudonymization.t line 214. # Looks like you failed 1 test of 3.
Created attachment 137952 [details] [review] Bug 31201: Prevent Pseudonymization.t to fail It's failing if selenium/patrons_search.t failed before, they are using the same code and the selenium tests didn't clean correctly
Created attachment 137954 [details] [review] Bug 31201: Prevent Pseudonymization.t to fail It's failing if selenium/patrons_search.t failed before, they are using the same code and the selenium tests didn't clean correctly Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
The change makes sense to me and makes us a little more future proof by using testbuilder. Passing QA
Pushed to master for 22.11. Nice work everyone, thanks!
Backported to 22.05.x for 22.05.05
Thanks! Pushed to 21.11 for 21.11.12
Not backported to oldoldstable (21.05.x). No recollection of this failing on 21.05.x, will keep in mind if Pseudonymization.t fails. Nothing to document, resolving