To recreate: 1 - Create a new label batch with some items 2 - Select 1 or more 3 - Export selected labels 4 - Download as PDF 5 - BOOM Can't locate object method "get_attr" via package "-2" (perhaps you forgot to load "-2"?) at /usr/share/koha/intranet/cgi-bin/labels/label-create-pdf.pl line 126. It looks like bug 26340 accidentally touched the selected label export and removed batch number and label ids
Created attachment 138009 [details] [review] BUg 31220: Pass label batch and ids to label-create-pdf This patch fixes a malformed link to print selected labels and fix error: Can't locate object method "get_attr" via package "-2" (perhaps you forgot to load "-2"?) at /usr/share/koha/intranet/cgi-bin/labels/label-create-pdf.pl line 126. To test: 1 - Create a new label batch with some items 2 - Select 1 or more 3 - Export selected labels 4 - Download as PDF 5 - It works!
Created attachment 138012 [details] [review] BUg 31220: Pass label batch and ids to label-create-pdf This patch fixes a malformed link to print selected labels and fix error: Can't locate object method "get_attr" via package "-2" (perhaps you forgot to load "-2"?) at /usr/share/koha/intranet/cgi-bin/labels/label-create-pdf.pl line 126. To test: 1 - Create a new label batch with some items 2 - Select 1 or more 3 - Export selected labels 4 - Download as PDF 5 - It works! Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Nice fix - works as described, so signing off. Thanks for the patch.
Are the warn Data::Dumper::Dumper forgotten there or are there logging improvements?
Created attachment 138479 [details] [review] Bug 31220: (follow-up) Remove debug statements
*** Bug 29994 has been marked as a duplicate of this bug. ***
Created attachment 138516 [details] [review] Bug 31220: Pass label batch and ids to label-create-pdf This patch fixes a malformed link to print selected labels and fix error: Can't locate object method "get_attr" via package "-2" (perhaps you forgot to load "-2"?) at /usr/share/koha/intranet/cgi-bin/labels/label-create-pdf.pl line 126. To test: 1 - Create a new label batch with some items 2 - Select 1 or more 3 - Export selected labels 4 - Download as PDF 5 - It works! Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 138517 [details] [review] Bug 31220: (QA follow-up) Add missing filter Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to master for 22.11. Nice work everyone, thanks!
Hey team, this bug is valid in Koha 21.11.x, can it please be backported?
Backported to 22.05.x for 22.05.04
pushed to 21.11.x for 21.11.11
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved.