Bug 31268 - Clearly indicate reason for failed item creation when receiving expired subscription
Summary: Clearly indicate reason for failed item creation when receiving expired subsc...
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-29 19:58 UTC by Andrew Fuerste-Henry
Modified: 2022-11-17 12:17 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2022-07-29 19:58:02 UTC
Bug 29188 points out that while the manual says one cannot receive issues in an expired subscription, Koha is currently allowing one to do so.

However, Koha *is* refusing to create an item when receiving an issue on an expired subscription. 

To recreate:
1 - create a subscription set to *not* create items, subscription end date in the past
2 - save subscription, confirm it shows as expired, confirm you can receive an issue anyway
3 - create a subscription set *to* create items, subscription end date in the past
4- save subscription, confirm it shows as expired, confirm you can get to the receiving page but setting the dropdown for the expected issue to "Arrived" does not cause an item edit box to appear
5- create a subscription set *to* create items, subscription end date in the future, number of issues set to 1
6- save subscription, receive 1 issue, confirm it works as intended
7- confirm subscription now shows a confusing "Subscription will expire on [subscription end date]" message even though the date isn't the problem
8- Attempt to receive another issue, confirm that now the item edit box won't pop up, as in step 4

In steps 4 and 8, the item edit box will appear if one attempts to receive a supplemental issue, but the item will refuse to save, giving an erroneous "missing required field" message.
Comment 1 Andrew Fuerste-Henry 2022-07-29 19:59:30 UTC
Obviously this bug will be moot if 29188 gets resolved in such a way that one can't get this far into receipt on an expired subscription.
Comment 2 Katrin Fischer 2022-11-17 12:17:40 UTC
I think we should fix that so items are still created while you can create issues.