Bug 31270 - Terminology: Standardize on self-registration or self registration
Summary: Terminology: Standardize on self-registration or self registration
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Nicolas Hunstein
QA Contact: Marcel de Rooy
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2022-07-30 14:24 UTC by Katrin Fischer
Modified: 2025-01-26 20:22 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes any occurrences of "self registration" (and variations) and changes these to "self-registration" for consistency in the OPAC and staff interface. It also updates the system preference description for PatronSelfRegistrationLibraryList.
Version(s) released in:
Circulation function:


Attachments
Bug 31270: standardize on self-registration (1.95 KB, patch)
2025-01-23 15:22 UTC, Nicolas Hunstein
Details | Diff | Splinter Review
Bug 31270: standardize on self-registration (2.01 KB, patch)
2025-01-23 19:55 UTC, William Lavoie
Details | Diff | Splinter Review
Bug 31270: update "self reg" (8.07 KB, patch)
2025-01-24 13:55 UTC, Nicolas Hunstein
Details | Diff | Splinter Review
Bug 31270: update "self reg" (8.38 KB, patch)
2025-01-24 14:10 UTC, Nicolas Hunstein
Details | Diff | Splinter Review
Bug 31270: Terminology - use "self-registration" (8.79 KB, patch)
2025-01-26 20:05 UTC, David Nind
Details | Diff | Splinter Review
Bug 31270: (follow-up) Fix description for PatronSelfRegistrationLibraryList (1.53 KB, patch)
2025-01-26 20:05 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-07-30 14:24:33 UTC
Currently we have a bit of a mix in the templates and the notices and I think it would be nice to standardize.

I found this, but happy with either as long as we are consistent:
https://www.merriam-webster.com/dictionary/self-registering
Comment 1 Katrin Fischer 2022-07-30 14:33:11 UTC
Maybe some native speaker can help?

According to coding guidelines we use AE spelling.
Comment 2 Katrin Fischer 2025-01-10 14:54:28 UTC
On mattermost the conclusion was to use self-...
Comment 3 Nicolas Hunstein 2025-01-23 15:22:40 UTC
Created attachment 177063 [details] [review]
Bug 31270: standardize on self-registration

updates description "selfregistration" to "self-registration"

to test:
- go to installer/data/mysql/updatedatabase.pl
- check there are descriptions in the form "selfregistration"

- apply patch
- descriptions are in the form "self-registration"
Comment 4 William Lavoie 2025-01-23 19:55:07 UTC
Created attachment 177074 [details] [review]
Bug 31270: standardize on self-registration

updates description "selfregistration" to "self-registration"

to test:
- go to installer/data/mysql/updatedatabase.pl
- check there are descriptions in the form "selfregistration"

- apply patch
- descriptions are in the form "self-registration"

Signed-off-by: William Lavoie <william.lavoie@inLibro.com>
Comment 5 Marcel de Rooy 2025-01-24 07:35:05 UTC
QA comment:

Not sure how useful it is to change old dbrevs in updatedatabase.
Note that I see various occurrences in the codebase for selfregistration and "self registration".
I would expect this report to change them too.

Note that updating old release notes and old dbrevs might not be needed imo. But references in active templates etc would.

Please use the Assignee field to put your name in. Now I did for you:)
Thanks.
Comment 6 Nicolas Hunstein 2025-01-24 13:55:20 UTC
Created attachment 177115 [details] [review]
Bug 31270: update "self reg"

updates string "self reg" to "self-reg"

to test:
- got to installer/data/mysql/mandatory/sysprt/db_dependent/Koha/Patronefs.sql, koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref, misc/cronjobs/cleanup_database.pl and t/db_dependent/Koha/Patron.t
- check there are strings in the form "self reg"

- apply patch
- strings are in the form "self-reg"
Comment 7 Nicolas Hunstein 2025-01-24 14:10:57 UTC
Created attachment 177116 [details] [review]
Bug 31270: update "self reg"

updates string "self reg" to "self-reg"

to test:
- got to installer/data/mysql/mandatory/sysprt/db_dependent/Koha/Patronefs.sql, koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref, misc/cronjobs/cleanup_database.pl and t/db_dependent/Koha/Patron.t
- check there are strings in the form "self reg"

- apply patch
- strings are in the form "self-reg"

@  Marcel de Rooy: Thank you very much for informing me that correcions in "updatedatabase" are neither necessary nor helpful and for adding my name to the Assignee field.
May you please tell me where I can still find the description "Selfregistration"? Currently I can only find it in the release notes and dbrevs.
Comment 8 David Nind 2025-01-26 20:05:52 UTC
Created attachment 177149 [details] [review]
Bug 31270: Terminology - use "self-registration"

Standardize on the use of "self-registration" (and variations)
for consistency in the OPAC and staff interface, instead of
"self registration".

Test plan:
1. Check the codebase for occurences of "self reg":
   . git grep "self reg"
   . git grep "selfreg"
   . git grep "Self reg"
   . git grep "Selfreg"
2. Note the occurences, excluding code comments, previous
   database updates, and previous release notes.
3. Search the system preferences for "self reg" and "selfreg".
4. Note the occurences in the results for the system preference
   descriptions (excluding system preference names) for:
   - PatronSelfRegistrationDefaultCategory
   - PatronSelfRegistrationEmailMustBeUnique
   - PatronSelfRegistrationLibraryList
   - PatronSelfRegistrationPrefillForm
5. Note the system preferences category heading for the OPAC
   - "Self registration and modification".
6. Apply the patch.
7. Repeat steps 1 to 5. There should now be no occurences
   (excluding code comments, previous database updates, and
   previous release notes).

Signed-off-by: David Nind <david@davidnind.com>
Comment 9 David Nind 2025-01-26 20:05:55 UTC
Created attachment 177150 [details] [review]
Bug 31270: (follow-up) Fix description for PatronSelfRegistrationLibraryList

Test plan:
1. Check that the updated description for the
   PatronSelfRegistrationLibraryList system preference makes sense.

Signed-off-by: David Nind <david@davidnind.com>
Comment 10 David Nind 2025-01-26 20:22:28 UTC
I've updated the commit message so that it is a bit more consistent with the commit message guidelines https://wiki.koha-community.org/wiki/Commit_messages

I also added a follow-up for the PatronSelfRegistrationLibraryList system preference (as "Enable the self-registration..." is incorrect), and also fixed the rest of the description at the same time.

As far as I can see, there are no other occurrences to change. (For PatronSelfRegistrationDefaultCategory, I think the values for the patron categories dropdown list (including Self registration) come from the sample data used by KTD.)

I've also updated the terminology guidelines https://wiki.koha-community.org/wiki/Terminology#S