Bug 3128 - IE7: Can't enter a new authority record: javascript error blocks save
Summary: IE7: Can't enter a new authority record: javascript error blocks save
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Browser compatibility (show other bugs)
Version: rel_3_0
Hardware: PC All
: PATCH-Sent (DO NOT USE) normal
Assignee: Galen Charlton
QA Contact:
URL: http://staff-dfs4.dev.kohalibrary.com...
Keywords: browser_compatibility
Depends on:
Blocks:
 
Reported: 2009-04-16 10:37 UTC by Chris Cormack
Modified: 2012-10-25 22:37 UTC (History)
2 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:06:47 UTC


---- Reported by daniel.sweeney@liblime.com 2009-04-16 22:37:30 ----

When saving a new authority record in authorities.pl, when the admin chooses "Save" at the bottom of the form, IE7 raises a javascript error: LIne 96, char 13, can't move focus to the control because it is invisible, not enabled or of a type that does not accept the focus. The new authority record cannot be saved. 

When using the top "save" button, there's no javascript error but the record does not save. (The button does not do anything.)

This happens for personal names, topical terms, and the other authority types.



---- Additional Comments From joe.atzberger@liblime.com 2009-04-22 21:17:07 ----

Patch sent.   



---- Additional Comments From daniel.sweeney@liblime.com 2009-04-22 22:19:57 ----

After applying this patch to HEAD, you get a javascript warning when entering the authorities area at authorities-home.pl: ine 338, char 3, Error: 'confirm_deletion' is undefined'. You can clear that warning and try to create a new authority record. You can click the 000, 003, 005, 008 and 040 fields to fill in the default data, and add something to the 1xx field. When you try to save the authority record, usign either of the save buttons, you get a sequence of dialog boxes reading "tag_000_subfield_00_676556_501285", "tag_003_subfield_00_<numbers>", "tag_005_subfield_00_<numbers>, tag_008_subfield_00_<numbers>, tag_040_subfield_a_<numbers>. If you use the top save button, the record is not saved; if you use the bottom save button, you get a javascript error: Line 101, character 9, error: 'flag' is undefined 

This is not IE-specific; I can replicate in Safari.  



---- Additional Comments From gmcharlt@gmail.com 2009-04-24 12:58:12 ----

Pushed the two patches that Joe submitted, which together resolve the problem originally reported.

The 'confirm_deletion' warning is a separate issue, not yet addressed by any patch.



---- Additional Comments From daniel.sweeney@liblime.com 2009-04-28 16:33:16 ----

Confirmed fixed.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:06 UTC  ---

This bug was previously known as _bug_ 3128 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3128

Actual time not defined. Setting to 0.0
The original reporter of this bug does not have
   an account here. Reassigning to the person who moved
   it here: chris@bigballofwax.co.nz.
   Previous reporter was daniel.sweeney@liblime.com.
The original assignee of this bug does not have
   an account here. Reassigning to the default assignee
   for the component, gmcharlt@gmail.com.
   Previous assignee was joe.atzberger@liblime.com.