Bug 31286 - Embed see-from headings into bibliographic records export
Summary: Embed see-from headings into bibliographic records export
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Fridolin Somers
QA Contact: Victor Grousset/tuxayo
URL:
Keywords:
Depends on:
Blocks: 32509
  Show dependency treegraph
 
Reported: 2022-08-03 01:16 UTC by Fridolin Somers
Modified: 2024-02-08 03:58 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 31286: Embed see-from headings into bibliographic records export (3.41 KB, patch)
2022-08-03 01:31 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 31286: Embed see-from headings into bibliographic records export (3.47 KB, patch)
2024-01-08 23:41 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 31286: Embed see-from headings into bibliographic records export (3.52 KB, patch)
2024-02-08 03:54 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review
Bug 31286: (QA follow-up): tidy up code (1.31 KB, patch)
2024-02-08 03:57 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2022-08-03 01:16:57 UTC
In misc/export_records.pl add an option to add see-from headings (from authorities 4xx) into bibliographic records export.
Like it is done during record indexing.
Comment 1 Fridolin Somers 2022-08-03 01:31:59 UTC
Created attachment 138520 [details] [review]
Bug 31286: Embed see-from headings into bibliographic records export

In misc/export_records.pl add an option to add see-from headings (from authorities 4xx) into bibliographic records export.
Like it is done during record indexing.

Test plan :
1) Choose a biblio record having a field (for example 650) linked to an authority with a see-form.
2) Export this record without see-from headings :
   misc/export_records.pl --starting_biblionumber=X --ending_biblionumber=X --filename /tmp/record_without.xml --format xml
3) Export this record with see-from headings :
   misc/export_records.pl --starting_biblionumber=X --ending_biblionumber=X --filename /tmp/record_with.xml --format xml --embed_see_from_headings
4) Compare /tmp/record_without.xml and /tmp/record_with.xml
=> you should see two 650, one with main heading and one with see-from heading
Comment 2 Katrin Fischer 2022-10-01 07:58:08 UTC
Please don't forget to set Assignee :)
Comment 3 Chris Cormack 2024-01-08 23:41:48 UTC
Created attachment 160672 [details] [review]
Bug 31286: Embed see-from headings into bibliographic records export

In misc/export_records.pl add an option to add see-from headings (from authorities 4xx) into bibliographic records export.
Like it is done during record indexing.

Test plan :
1) Choose a biblio record having a field (for example 650) linked to an authority with a see-form.
2) Export this record without see-from headings :
   misc/export_records.pl --starting_biblionumber=X --ending_biblionumber=X --filename /tmp/record_without.xml --format xml
3) Export this record with see-from headings :
   misc/export_records.pl --starting_biblionumber=X --ending_biblionumber=X --filename /tmp/record_with.xml --format xml --embed_see_from_headings
4) Compare /tmp/record_without.xml and /tmp/record_with.xml
=> you should see two 650, one with main heading and one with see-from heading

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 4 Victor Grousset/tuxayo 2024-02-08 03:54:00 UTC
Created attachment 161875 [details] [review]
Bug 31286: Embed see-from headings into bibliographic records export

In misc/export_records.pl add an option to add see-from headings (from authorities 4xx) into bibliographic records export.
Like it is done during record indexing.

Test plan :
1) Choose a biblio record having a field (for example 650) linked to an authority with a see-form.
2) Export this record without see-from headings :
   misc/export_records.pl --starting_biblionumber=X --ending_biblionumber=X --filename /tmp/record_without.xml --format xml
3) Export this record with see-from headings :
   misc/export_records.pl --starting_biblionumber=X --ending_biblionumber=X --filename /tmp/record_with.xml --format xml --embed_see_from_headings
4) Compare /tmp/record_without.xml and /tmp/record_with.xml
=> you should see two 650, one with main heading and one with see-from heading

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 5 Victor Grousset/tuxayo 2024-02-08 03:57:50 UTC
Created attachment 161876 [details] [review]
Bug 31286: (QA follow-up): tidy up code
Comment 6 Victor Grousset/tuxayo 2024-02-08 03:58:12 UTC
Works, makes sense, QA script happy, code looks good, passing QA :)