Bug 31312 - Remove GetItemsInfo from misc/migration_tools/rebuild_zebra.pl
Summary: Remove GetItemsInfo from misc/migration_tools/rebuild_zebra.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 31306
Blocks: 27272
  Show dependency treegraph
 
Reported: 2022-08-08 14:22 UTC by Jonathan Druart
Modified: 2023-06-08 22:26 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31312: Remove GetItemsInfo from misc/migration_tools/rebuild_zebra.pl (2.06 KB, patch)
2022-08-08 14:47 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 31312: Remove GetItemsInfo from misc/migration_tools/rebuild_zebra.pl (2.11 KB, patch)
2022-08-08 17:48 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31312: Remove GetItemsInfo from misc/migration_tools/rebuild_zebra.pl (2.17 KB, patch)
2022-08-10 12:18 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2022-08-08 14:22:45 UTC
Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search_ordered.

Here we are going to deal with misc/migration_tools/rebuild_zebra.pl
Comment 1 Jonathan Druart 2022-08-08 14:47:54 UTC
Created attachment 138820 [details] [review]
Bug 31312: Remove GetItemsInfo from misc/migration_tools/rebuild_zebra.pl

Hum... Item2Marc ok here?

Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search.

Here we are going to deal with misc/migration_tools/rebuild_zebra.pl

Test plan:
I am not sure, what do we want to test here? Items' info indexed
correctly?
Comment 2 Owen Leonard 2022-08-08 17:48:09 UTC
Created attachment 138846 [details] [review]
Bug 31312: Remove GetItemsInfo from misc/migration_tools/rebuild_zebra.pl

Hum... Item2Marc ok here?

Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search.

Here we are going to deal with misc/migration_tools/rebuild_zebra.pl

Test plan:
I am not sure, what do we want to test here? Items' info indexed
correctly?

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Owen Leonard 2022-08-08 17:48:50 UTC
> Test plan:
> I am not sure, what do we want to test here? Items' info indexed
> correctly?

The process completes correctly and the results appear to be up to date.
Comment 4 Nick Clemens 2022-08-10 12:18:01 UTC
Created attachment 138979 [details] [review]
Bug 31312: Remove GetItemsInfo from misc/migration_tools/rebuild_zebra.pl

Hum... Item2Marc ok here?

Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search.

Here we are going to deal with misc/migration_tools/rebuild_zebra.pl

Test plan:
I am not sure, what do we want to test here? Items' info indexed
correctly?

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 5 Tomás Cohen Arazi 2022-08-16 13:53:56 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!