Bug 31321 - Remove GetItemsInfo from catalogue/detail.pl
Summary: Remove GetItemsInfo from catalogue/detail.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Jonathan Druart
QA Contact: Joonas Kylmälä
URL:
Keywords:
Depends on: 31306
Blocks: 27272 32908
  Show dependency treegraph
 
Reported: 2022-08-08 14:23 UTC by Jonathan Druart
Modified: 2023-12-28 20:43 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Circulation function:


Attachments
Bug 31321: Remove GetItemsInfo from catalogue/detail.pl (21.54 KB, patch)
2022-08-08 14:53 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 31321: Remove GetItemsInfo from catalogue/detail.pl (21.59 KB, patch)
2022-08-09 13:30 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31321: Fix 'Used in' (938 bytes, patch)
2022-08-15 08:06 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 31321: Fix copynumber (1.19 KB, patch)
2022-08-15 08:08 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 31321: Remove GetItemsInfo from catalogue/detail.pl (21.93 KB, patch)
2022-08-19 20:58 UTC, Joonas Kylmälä
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2022-08-08 14:23:17 UTC
Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search_ordered.

Here we are going to deal with catalogue/detail.pl
Comment 1 Jonathan Druart 2022-08-08 14:53:43 UTC
Created attachment 138831 [details] [review]
Bug 31321: Remove GetItemsInfo from catalogue/detail.pl

Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search_ordered.

Here we are going to deal with catalogue/detail

Test plan:
List items on the modified view and confirm that all the info is
displayed correctly
Comment 2 Owen Leonard 2022-08-09 13:30:24 UTC
Created attachment 138913 [details] [review]
Bug 31321: Remove GetItemsInfo from catalogue/detail.pl

Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search_ordered.

Here we are going to deal with catalogue/detail

Test plan:
List items on the modified view and confirm that all the info is
displayed correctly

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Joonas Kylmälä 2022-08-14 14:50:46 UTC
After applying this patch the link to analytical record is not shown in the items list of the detail.pl page. To reproduce:

1) Apply patch
2) Enable EasyAnalyticalRecords syspref
3) Go to any biblio's page with items
4) Click New => analyze items.
5) Click on the link on any item that says "Create analytics" and proceed with the record creation.
6) Go back to the biblio page and notice "Used in" tab doesn't contain the link to the analytics record (without this patch it contains.)
Comment 4 Jonathan Druart 2022-08-15 08:06:22 UTC
Created attachment 139115 [details] [review]
Bug 31321: Fix 'Used in'
Comment 5 Jonathan Druart 2022-08-15 08:06:59 UTC
Thanks, Joonas!
Feel free to squash the follow-up patch.
Comment 6 Jonathan Druart 2022-08-15 08:08:10 UTC
Created attachment 139116 [details] [review]
Bug 31321: Fix copynumber
Comment 7 Joonas Kylmälä 2022-08-19 20:58:25 UTC
Created attachment 139523 [details] [review]
Bug 31321: Remove GetItemsInfo from catalogue/detail.pl

Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search_ordered.

Here we are going to deal with catalogue/detail

Test plan:
List items on the modified view and confirm that all the info is
displayed correctly

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
JK: Amend follow-up fixes from Joubu to this patch

Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Comment 8 Tomás Cohen Arazi (tcohen) 2022-08-22 16:19:06 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 9 Lucas Gass (lukeg) 2022-10-14 19:52:03 UTC
Enhancement will not be backported to 22.05.x series