Bug 31353 - Improve display of lost items when placing holds in OPAC
Summary: Improve display of lost items when placing holds in OPAC
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 31314
Blocks:
  Show dependency tree / graph
 
Reported: 2022-08-12 15:09 UTC by Katrin Fischer
Modified: 2022-08-18 15:38 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-08-12 15:09:45 UTC 
Bug 31314 revealed some oddness in our display of lost items. 

It changed from:
        # Management of lost or long overdue items
-        if ( $itemInfo->{itemlost} ) {
-
-            # FIXME localized strings should never be in Perl code
-            $itemLoopIter->{message} =
-                $itemInfo->{itemlost} == 1 ? "(lost)"
-              : $itemInfo->{itemlost} == 2 ? "(long overdue)"
-              : "";
-            $itemInfo->{backgroundcolor} = 'other';
-        }

To: 
+                                                                [% IF ( itemLoo.itemlost == 1 || itemLoo.itemlost == 2 ) %] [%# FIXME Why only for 1 or 2? Shouldn't we test for withdrawn as well? %]
                                                                     <span class="lost">Unavailable (lost or missing)</span>
                                                                 [% END %]


Indeed we should display the description of the LOST authorised value here for all authorised values that are > 0.