If you don't provide a $query argument for C4::Templates::gettemplate it will warn, but it's just passing the $query object to C4::Languages::getlanguage() which is often invoked in Koha without it. It's a totally unnecessary warning.
Created attachment 139310 [details] [review] Bug 31390: Remove noisy warns in C4::Templates This patch removes two noisy warnings from C4::Templates 0) Apply patch and koha-plack --restart kohadev 1) Go to http://localhost:8081/ 2) Note no warnings in /var/log/koha/kohadev/plack-intranet-error.log 3) Go to http://localhost:8080/ 3) Note no warnings in /var/log/koha/kohadev/plack-opac-error.log
Created attachment 139397 [details] [review] Bug 31390: Remove noisy warns in C4::Templates This patch removes two noisy warnings from C4::Templates 0) Apply patch and koha-plack --restart kohadev 1) Go to http://localhost:8081/ 2) Note no warnings in /var/log/koha/kohadev/plack-intranet-error.log 3) Go to http://localhost:8080/ 3) Note no warnings in /var/log/koha/kohadev/plack-opac-error.log Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 139533 [details] [review] Bug 31390: Remove noisy warns in C4::Templates This patch removes two noisy warnings from C4::Templates 0) Apply patch and koha-plack --restart kohadev 1) Go to http://localhost:8081/ 2) Note no warnings in /var/log/koha/kohadev/plack-intranet-error.log 3) Go to http://localhost:8080/ 3) Note no warnings in /var/log/koha/kohadev/plack-opac-error.log Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Pushed to master for 22.11. Nice work everyone, thanks!
Backported to 22.05.x for upcoming 22.05.06 release
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved.
Thanks! Pushed to 21.11 for 21.11.12