Bug 31396 - OPAC shelf browser broken after removal GetItemsInfo from opac-detail
Summary: OPAC shelf browser broken after removal GetItemsInfo from opac-detail
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low major (vote)
Assignee: Tomás Cohen Arazi
QA Contact: Joonas Kylmälä
URL:
Keywords:
Depends on: 31313
Blocks:
  Show dependency treegraph
 
Reported: 2022-08-18 18:13 UTC by Owen Leonard
Modified: 2023-06-08 22:26 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31396: Fix incorrect attribute access in opac-detail.pl (1.18 KB, patch)
2022-09-07 15:52 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 31396: Fix incorrect attribute access in opac-detail.pl (1.32 KB, patch)
2022-09-07 16:17 UTC, Joonas Kylmälä
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2022-08-18 18:13:25 UTC
The OPAC detail page works fine but if you click any "Browse shelf" link it will trigger an error:

Can't call method "itemnumber" on unblessed reference at /kohadevbox/koha/opac/opac-detail.pl line 1117
Comment 1 Katrin Fischer 2022-09-07 08:20:33 UTC
Cofirmed!
Comment 2 Tomás Cohen Arazi 2022-09-07 15:52:19 UTC
Created attachment 140317 [details] [review]
Bug 31396: Fix incorrect attribute access in opac-detail.pl

To test:
1. Have an item with a callnumber defined
2. Have OPACShelfBrowser enabled
3. Open the record detailed view in the OPAC
4. Click on 'Browse shelf'
=> FAIL: It explodes
5. Apply this patch
6. Repeat 4
=> SUCCESS: It works!
7. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 3 Joonas Kylmälä 2022-09-07 16:17:12 UTC
Created attachment 140321 [details] [review]
Bug 31396: Fix incorrect attribute access in opac-detail.pl

To test:
1. Have an item with a callnumber defined
2. Have OPACShelfBrowser enabled
3. Open the record detailed view in the OPAC
4. Click on 'Browse shelf'
=> FAIL: It explodes
5. Apply this patch
6. Repeat 4
=> SUCCESS: It works!
7. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Comment 4 Joonas Kylmälä 2022-09-07 16:17:38 UTC
Trivial, straight to PQA.
Comment 5 Tomás Cohen Arazi 2022-09-07 23:43:53 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!