We changed the heading and the administration start page to say 'Classification configuration' but missed changing the administration sidebar as well.
There are some more discrepancies between the admin start page and the sidebar, will detail in the commit message.
Created attachment 139436 [details] [review] Bug 31401: Update administration sidebar to match entries on administration start page This makes sure that all entries on the administration start page have a matching entry in the administration sidebar that shows on the left side if you are on any of the administration sub pages. Changes made: * Rename 'Classification sources' to 'Classification configuration' * Make Plugins entry show and appear in correct spot This relied on the variable plugins_enabled that wasn't available in all the different templates. I therefore moved it to Auth.pm and cleaned up the code for the admin start page. * Move 'MARC overlay rules' and rename to 'Record overlay rules' To test: * Make sure plugins are enabled and visible on admin start page * Compare admin start page and sidebar * Sequence should be the same * All entries should appear on both pages * Naming should be the same
Created attachment 139445 [details] [review] Bug 31401: Update administration sidebar to match entries on administration start page This makes sure that all entries on the administration start page have a matching entry in the administration sidebar that shows on the left side if you are on any of the administration sub pages. Changes made: * Rename 'Classification sources' to 'Classification configuration' * Make Plugins entry show and appear in correct spot This relied on the variable plugins_enabled that wasn't available in all the different templates. I therefore moved it to Auth.pm and cleaned up the code for the admin start page. * Move 'MARC overlay rules' and rename to 'Record overlay rules' To test: * Make sure plugins are enabled and visible on admin start page * Compare admin start page and sidebar * Sequence should be the same * All entries should appear on both pages * Naming should be the same Signed-off-by: David Nind <david@davidnind.com>
I've signed off, but noted that when you go into Administration > Plugins > Manage plugins that the sidebar for Tools appears (it is listed under Additional tools > Tool plugins - I vaguely recall plugins was located there at some stage...). I'm going to assume that this should be a separate bug (if it isn't already). Everything else looks great and matches up!
Plugins appear on both start pages - administration and tools. But the files themselves live in the tools section. That's why you land there, when you click on it. It's a little similar to the funds/budgets that live in admin, but are also on the sidebar in acq. I just repaired the Plugins entry, it was always supposed to show but didn't because of a problem with the plugins_enable variable.
Created attachment 140151 [details] [review] Bug 31401: Update administration sidebar to match entries on administration start page This makes sure that all entries on the administration start page have a matching entry in the administration sidebar that shows on the left side if you are on any of the administration sub pages. Changes made: * Rename 'Classification sources' to 'Classification configuration' * Make Plugins entry show and appear in correct spot This relied on the variable plugins_enabled that wasn't available in all the different templates. I therefore moved it to Auth.pm and cleaned up the code for the admin start page. * Move 'MARC overlay rules' and rename to 'Record overlay rules' To test: * Make sure plugins are enabled and visible on admin start page * Compare admin start page and sidebar * Sequence should be the same * All entries should appear on both pages * Naming should be the same Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 140152 [details] [review] Bug 31401: (QA follow-up) Remove Koha.ArePluginsEnabled, it is no longer needed Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master for 22.11. Nice work everyone, thanks!
Backported to 22.05.x for upcoming 22.05.07 release
applied to 21.11.x for 21.11.14
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved.