Bug 31410 - Set focus for cursor to Server name when adding a new Z39.50 or SRU server
Summary: Set focus for cursor to Server name when adding a new Z39.50 or SRU server
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2022-08-18 21:59 UTC by Katrin Fischer
Modified: 2023-07-20 02:41 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06,22.05.14, 22.11.22


Attachments
Bug 31410: Set focus for cursor to Server name when adding a new Z39.50/SRU server (2.09 KB, patch)
2023-02-05 00:19 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31410: Set focus for cursor to Server name when adding a new Z39.50/SRU server (2.14 KB, patch)
2023-02-06 13:00 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31410: Set focus for cursor to Server name when adding a new Z39.50/SRU server (2.19 KB, patch)
2023-04-28 16:25 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-08-18 21:59:21 UTC
When adding a new SRU or Z39.50 server from administration, the focus should be in the first input field of each form: Server name.
Comment 1 Katrin Fischer 2023-02-05 00:19:07 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2023-02-06 13:00:59 UTC
Created attachment 146265 [details] [review]
Bug 31410: Set focus for cursor to Server name when adding a new Z39.50/SRU server

This makes sure that the focus is in the first form field when
adding a new Z39.50 or SRU server.

To test:
* Administration > Z39.50/SRU servers
* Add a new server for each
* Verify the focus is not in the form
* Apply patch
* Verify the focus is now in the first form field
* Edit an existing server
* Verify the focus is not in the form

Not having the focus when editing is to avoid accidental changes.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Jonathan Druart 2023-02-23 10:39:34 UTC
(In reply to Owen Leonard from comment #2)
> Not having the focus when editing is to avoid accidental changes.

Is that done somewhere else?
Comment 4 Jonathan Druart 2023-03-24 10:33:47 UTC
Waiting for an answer.
Comment 5 Katrin Fischer 2023-03-24 10:36:40 UTC
(In reply to Jonathan Druart from comment #3)
> (In reply to Owen Leonard from comment #2)
> > Not having the focus when editing is to avoid accidental changes.
> 
> Is that done somewhere else?

Yes it is, I was starting to make a list, but not finding my notes now. I'll revisit if you want, but there is some precedence, maybe not consistency (yet)
Comment 6 Katrin Fischer 2023-04-23 15:45:26 UTC
Other places we do this:
* Bug 31410 - Set focus for cursor to Server name when adding a new Z39.50 or SRU server
* Bug 27458 - Set focus for cursor to Credit type code field when creating new credit type
* Bug 27192 - Set focus for cursor to item type input box when creating new item types - comment 8 has some notes about a prvious discussion on this too
Comment 7 Nick Clemens 2023-04-28 16:25:51 UTC
Created attachment 150398 [details] [review]
Bug 31410: Set focus for cursor to Server name when adding a new Z39.50/SRU server

This makes sure that the focus is in the first form field when
adding a new Z39.50 or SRU server.

To test:
* Administration > Z39.50/SRU servers
* Add a new server for each
* Verify the focus is not in the form
* Apply patch
* Verify the focus is now in the first form field
* Edit an existing server
* Verify the focus is not in the form

Not having the focus when editing is to avoid accidental changes.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 8 Tomás Cohen Arazi 2023-05-05 15:14:35 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 9 Martin Renvoize 2023-05-12 15:23:48 UTC
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release
Comment 10 Lucas Gass 2023-06-13 16:17:51 UTC
Backported to 22.05.x for upcoming 22.05.14.
Comment 11 Danyon Sewell 2023-07-20 02:41:06 UTC
Backported to 21.11.x for upcoming 21.11.22