When adding a new SRU or Z39.50 server from administration, the focus should be in the first input field of each form: Server name.
Created attachment 146180 [details] [review] Bug 31410: Set focus for cursor to Server name when adding a new Z39.50/SRU server This makes sure that the focus is in the first form field when adding a new Z39.50 or SRU server. To test: * Administration > Z39.50/SRU servers * Add a new server for each * Verify the focus is not in the form * Apply patch * Verify the focus is now in the first form field * Edit an existing server * Verify the focus is not in the form Not having the focus when editing is to avoid accidental changes.
Created attachment 146265 [details] [review] Bug 31410: Set focus for cursor to Server name when adding a new Z39.50/SRU server This makes sure that the focus is in the first form field when adding a new Z39.50 or SRU server. To test: * Administration > Z39.50/SRU servers * Add a new server for each * Verify the focus is not in the form * Apply patch * Verify the focus is now in the first form field * Edit an existing server * Verify the focus is not in the form Not having the focus when editing is to avoid accidental changes. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
(In reply to Owen Leonard from comment #2) > Not having the focus when editing is to avoid accidental changes. Is that done somewhere else?
Waiting for an answer.
(In reply to Jonathan Druart from comment #3) > (In reply to Owen Leonard from comment #2) > > Not having the focus when editing is to avoid accidental changes. > > Is that done somewhere else? Yes it is, I was starting to make a list, but not finding my notes now. I'll revisit if you want, but there is some precedence, maybe not consistency (yet)
Other places we do this: * Bug 31410 - Set focus for cursor to Server name when adding a new Z39.50 or SRU server * Bug 27458 - Set focus for cursor to Credit type code field when creating new credit type * Bug 27192 - Set focus for cursor to item type input box when creating new item types - comment 8 has some notes about a prvious discussion on this too
Created attachment 150398 [details] [review] Bug 31410: Set focus for cursor to Server name when adding a new Z39.50/SRU server This makes sure that the focus is in the first form field when adding a new Z39.50 or SRU server. To test: * Administration > Z39.50/SRU servers * Add a new server for each * Verify the focus is not in the form * Apply patch * Verify the focus is now in the first form field * Edit an existing server * Verify the focus is not in the form Not having the focus when editing is to avoid accidental changes. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 23.05. Nice work everyone, thanks!
Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release
Backported to 22.05.x for upcoming 22.05.14.
Backported to 21.11.x for upcoming 21.11.22