When adding a new audio alert from the administration module, the focus should be on the first input field of the entry form: Selector
The focus class on the input field has no effect here. Owen, maybe you could take a look and make a suggestion?
Created attachment 146266 [details] [review] Bug 31413: Set focus for cursor to Selector when adding a new audio alert This patch adds a step to the process of displaying the new audio alert form so that focus will be set to the first field when the form has finished appearing. The typical "focus" class only works on elements which are present in the initial DOM when the page is displayed. To test, apply the patch and go to Administration -> Audio alerts. Click the "New alert" button. When the form appears cursor focus should be on the "Selector" field. Also test the edit process: When editing an existing alert there should not be automatic cursor focus.
Created attachment 146279 [details] [review] Bug 31413: Set focus for cursor to Selector when adding a new audio alert This patch adds a step to the process of displaying the new audio alert form so that focus will be set to the first field when the form has finished appearing. The typical "focus" class only works on elements which are present in the initial DOM when the page is displayed. To test, apply the patch and go to Administration -> Audio alerts. Click the "New alert" button. When the form appears cursor focus should be on the "Selector" field. Also test the edit process: When editing an existing alert there should not be automatic cursor focus. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 147355 [details] [review] Bug 31413: Set focus for cursor to Selector when adding a new audio alert This patch adds a step to the process of displaying the new audio alert form so that focus will be set to the first field when the form has finished appearing. The typical "focus" class only works on elements which are present in the initial DOM when the page is displayed. To test, apply the patch and go to Administration -> Audio alerts. Click the "New alert" button. When the form appears cursor focus should be on the "Selector" field. Also test the edit process: When editing an existing alert there should not be automatic cursor focus. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x
Backported to 22.05.x for upcoming 22.05.11
applied to 21.11 for 21.11.19
Not backported to 21.05.x