Created attachment 139796 [details] [review] Bug 31463: Add order status to opac-detail.pl This adds a check for the preference OPACAcquisitionDetails and fetches the active orders for the item if necessary Additionally, we simply the check for biblio orders to use object methods and remove code that stored order information in the item_info To test: 1 - Enable preference: OPACAcquisitionDetails 2 - Create a basket with items created on order, add an order for a biblio, close the basket 3 - Create a second basket as above, add an order with multiple copies, leave basket open 4 - View biblio on opac 5 - You should see 1 item marked on order, and "1 items on order" below items table 6 - Close second basket 7 - Reload opac view, now 3 on order and in message 8 - Reopen first basket 9 - Reload opac view, now 2 on order and in message
Looks like this didn't apply correctly? When I try to view opac-detail for any bib I get: Could not compile /kohadevbox/koha/opac/opac-detail.pl: Version control conflict marker at /kohadevbox/koha/opac/opac-detail.pl line 723, near "<<<<<<<" Version control conflict marker at /kohadevbox/koha/opac/opac-detail.pl line 727, near "=======" Version control conflict marker at /kohadevbox/koha/opac/opac-detail.pl line 739, near ">>>>>>>" BEGIN not safe after errors--compilation aborted at /kohadevbox/koha/opac/opac-detail.pl line 1261. at /usr/share/perl5/CGI/Compile.pm line 144
Created attachment 139996 [details] [review] Bug 31463: Add order status to opac-detail.pl This adds a check for the preference OPACAcquisitionDetails and fetches the active orders for the item if necessary Additionally, we simply the check for biblio orders to use object methods and remove code that stored order information in the item_info To test: 1 - Enable preference: OPACAcquisitionDetails 2 - Create a basket with items created on order, add an order for a biblio, close the basket 3 - Create a second basket as above, add an order with multiple copies, leave basket open 4 - View biblio on opac 5 - You should see 1 item marked on order, and "1 items on order" below items table 6 - Close second basket 7 - Reload opac view, now 3 on order and in message 8 - Reopen first basket 9 - Reload opac view, now 2 on order and in message
Created attachment 140010 [details] [review] Bug 31463: Add order status to opac-detail.pl This adds a check for the preference OPACAcquisitionDetails and fetches the active orders for the item if necessary Additionally, we simply the check for biblio orders to use object methods and remove code that stored order information in the item_info To test: 1 - Enable preference: OPACAcquisitionDetails 2 - Create a basket with items created on order, add an order for a biblio, close the basket 3 - Create a second basket as above, add an order with multiple copies, leave basket open 4 - View biblio on opac 5 - You should see 1 item marked on order, and "1 items on order" below items table 6 - Close second basket 7 - Reload opac view, now 3 on order and in message 8 - Reopen first basket 9 - Reload opac view, now 2 on order and in message JK: Remove unused @itemnumbers_on_order variable Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Created attachment 141112 [details] [review] Bug 31463: Add order status to opac-detail.pl This adds a check for the preference OPACAcquisitionDetails and fetches the active orders for the item if necessary Additionally, we simply the check for biblio orders to use object methods and remove code that stored order information in the item_info To test: 1 - Enable preference: OPACAcquisitionDetails 2 - Create a basket with items created on order, add an order for a biblio, close the basket 3 - Create a second basket as above, add an order with multiple copies, leave basket open 4 - View biblio on opac 5 - You should see 1 item marked on order, and "1 items on order" below items table 6 - Close second basket 7 - Reload opac view, now 3 on order and in message 8 - Reopen first basket 9 - Reload opac view, now 2 on order and in message JK: Remove unused @itemnumbers_on_order variable Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 141113 [details] [review] Bug 31463: (QA follow-up) Remove obsolete comment Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 22.11. Nice work everyone, thanks!
Not sure what needs documenting here, it seems like backend changes.