Bug 31481 - Pass message_id to SMS drivers
Summary: Pass message_id to SMS drivers
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Johanna Räisä
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-29 06:07 UTC by Johanna Räisä
Modified: 2024-05-28 06:06 UTC (History)
2 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 31481: pass message_id to SMS drivers (1.50 KB, patch)
2022-08-29 07:39 UTC, Johanna Räisä
Details | Diff | Splinter Review
Bug 31481: pass message_id to SMS drivers (1.55 KB, patch)
2022-09-12 20:39 UTC, David Nind
Details | Diff | Splinter Review
Bug 31481: pass message_id to SMS drivers (2.83 KB, patch)
2023-10-31 12:14 UTC, Johanna Räisä
Details | Diff | Splinter Review
Bug 31481: pass message_id to SMS drivers (2.89 KB, patch)
2024-01-12 16:07 UTC, Matthias Le Gac
Details | Diff | Splinter Review
Bug 31481: pass message_id to SMS drivers (3.07 KB, patch)
2024-05-28 06:06 UTC, Johanna Räisä
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Johanna Räisä 2022-08-29 06:07:33 UTC
Most of the SMS Gateways support REST API and it is common that the operator sends their report back to the service. Now it is impossible to catch reports if sms was succesfully sent or it failed since we can't pass the message_id to our report url when sending the message to the gateway.
Comment 1 Johanna Räisä 2022-08-29 07:39:28 UTC
Created attachment 139938 [details] [review]
Bug 31481: pass message_id to SMS drivers

This patch adds message_id to _send_message_by_sms and sms_send
so the driver could be build to catch SMS gateways delivery report.

Test plan:
1) Apply the patch
2) prove t/SMS.t

Sponsored-by: Koha-Suomi Oy
Comment 2 David Nind 2022-09-12 20:39:40 UTC
Created attachment 140507 [details] [review]
Bug 31481: pass message_id to SMS drivers

This patch adds message_id to _send_message_by_sms and sms_send
so the driver could be build to catch SMS gateways delivery report.

Test plan:
1) Apply the patch
2) prove t/SMS.t

Sponsored-by: Koha-Suomi Oy

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Marcel de Rooy 2022-09-30 09:55:45 UTC
+++ b/t/SMS.t
@@ -57,6 +57,7 @@ $send_sms = C4::SMS->send_sms({
     destination => '+33123456789',
     message => 'my message',
     driver => 'Test',
+    message_id => 1,

Please explain what this should prove ?
Comment 4 Johanna Räisä 2023-10-31 12:14:39 UTC
Created attachment 158114 [details] [review]
Bug 31481: pass message_id to SMS drivers

This patch adds message_id to _send_message_by_sms and sms_send
so the driver could be build to catch SMS gateways delivery report.

Test plan:
1) Apply the patch
2) prove t/SMS.t

Sponsored-by: Koha-Suomi Oy
Comment 5 Johanna Räisä 2023-10-31 12:17:19 UTC
(In reply to Marcel de Rooy from comment #3)
> +++ b/t/SMS.t
> @@ -57,6 +57,7 @@ $send_sms = C4::SMS->send_sms({
>      destination => '+33123456789',
>      message => 'my message',
>      driver => 'Test',
> +    message_id => 1,
> 
> Please explain what this should prove ?

I'm not sure anymore. I fixed the tests and message_id is required parameter.
Comment 6 Matthias Le Gac 2024-01-12 16:07:05 UTC
Created attachment 160986 [details] [review]
Bug 31481: pass message_id to SMS drivers

This patch adds message_id to _send_message_by_sms and sms_send
so the driver could be build to catch SMS gateways delivery report.

Test plan:
1) Apply the patch
2) prove t/SMS.t

Sponsored-by: Koha-Suomi Oy
Signed-off-by: matthias le gac <matthias.le-gac@inlibro.com>
Comment 7 Johanna Räisä 2024-05-28 06:06:04 UTC
Created attachment 167206 [details] [review]
Bug 31481: pass message_id to SMS drivers

This patch adds message_id to _send_message_by_sms and sms_send
so the driver could be build to catch SMS gateways delivery report.

Test plan:
1) Apply the patch
2) prove t/SMS.t

Sponsored-by: Koha-Suomi Oy
Signed-off-by: matthias le gac <matthias.le-gac@inlibro.com>
Comment 8 Johanna Räisä 2024-05-28 06:06:54 UTC
The patch is now fixed.