Bug 31495 - Allow viewing CMS pages when enforcing GDPR policy
Summary: Allow viewing CMS pages when enforcing GDPR policy
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Authentication (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Marcel de Rooy
QA Contact: Kyle M Hall (khall)
URL:
Keywords:
Depends on:
Blocks: 18081
  Show dependency treegraph
 
Reported: 2022-08-31 11:55 UTC by Marcel de Rooy
Modified: 2023-06-08 22:28 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Circulation function:


Attachments
Bug 31495: Allow opac-page when enforcing GDPR policy (1.17 KB, patch)
2022-08-31 12:04 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 31495: Allow opac-page when enforcing GDPR policy (1.18 KB, patch)
2022-09-14 22:09 UTC, David Nind
Details | Diff | Splinter Review
Bug 31495: Allow opac-page when enforcing GDPR policy (1.24 KB, patch)
2022-10-07 14:49 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2022-08-31 11:55:52 UTC
Very tiny adjustment in Auth module:
When the user gave no consent yet, we could allow him to see opac-page.pl. These are actually CMS pages that could be viewed as standing next to the library catalogue. It also allows you to use opac-page for the privacy policy page.
Comment 1 Marcel de Rooy 2022-08-31 12:04:22 UTC
Created attachment 140001 [details] [review]
Bug 31495: Allow opac-page when enforcing GDPR policy

Test plan:
Add some page under Additional contents.
Enforce GDPR policy.
Test with user that has no consent (yet or anymore).
Check if you can reach additional contents with opac-page.pl.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2022-09-14 14:39:57 UTC
Note for testers or QA: We do not need this patch to handle anonymous access to opac-page.pl. If it is an opac page, it will show when not logged in. But this patch allows a logged in user to access opac-page while enforcing GDPR and not having given a consent yet. (He could e.g. read the privacy policy when that is implemented under additional contents.)
Comment 3 David Nind 2022-09-14 22:09:38 UTC
Created attachment 140643 [details] [review]
Bug 31495: Allow opac-page when enforcing GDPR policy

Test plan:
Add some page under Additional contents.
Enforce GDPR policy.
Test with user that has no consent (yet or anymore).
Check if you can reach additional contents with opac-page.pl.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Marcel de Rooy 2022-09-15 05:34:50 UTC
(In reply to David Nind from comment #3)
> Signed-off-by: David Nind <david@davidnind.com>

Thx
Comment 5 Kyle M Hall (khall) 2022-10-07 14:49:04 UTC
Created attachment 141513 [details] [review]
Bug 31495: Allow opac-page when enforcing GDPR policy

Test plan:
Add some page under Additional contents.
Enforce GDPR policy.
Test with user that has no consent (yet or anymore).
Check if you can reach additional contents with opac-page.pl.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Tomás Cohen Arazi (tcohen) 2022-10-24 20:37:46 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!