If I go place a hold on staff interface (request.pl) and the staff member logged in has "Lost items in staff interface" setting set to "Hidden by default" in the patron category settings and a biblio has a lost item then we get on the page the following link: > Show all items ( hidden) The lost/hidden item count is missing due to a syntax error, it should read: > Show all items (1 hidden)
Created attachment 140198 [details] [review] Bug 31518: Fix syntax error on request.tt that prevents showing hidden item count The variable set by request.pl doesn't have biblio prefix, it is just hiddencount. To test: 1) Log in with a staff member account that has "Lost items in staff interface" setting set to "Hidden by default" in the patron category settings 2) Add a lost item to biblio 3) Go place a hold on staff interface (request.pl) notice the broken link on the request page: "Show all items ( hidden)" 4) After applying the patch it should read "Show all items (1 hidden)"
Created attachment 140268 [details] [review] Bug 31518: Fix syntax error on request.tt that prevents showing hidden item count The variable set by request.pl doesn't have biblio prefix, it is just hiddencount. To test: 1) Log in with a staff member account that has "Lost items in staff interface" setting set to "Hidden by default" in the patron category settings 2) Add a lost item to biblio 3) Go place a hold on staff interface (request.pl) notice the broken link on the request page: "Show all items ( hidden)" 4) After applying the patch it should read "Show all items (1 hidden)" Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Great catch, thx Joonas! Moving to PQA directly as this is an obvious template variable fix.
Pushed to master for 22.11. Nice work everyone, thanks!
Backported to 22.05.x for upcoming 22.05.07 release
applied to 21.11 for 21.11.14
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved.