Some users want to display a custom message to patrons self returning items that are on hold.
Created attachment 140212 [details] [review] Bug 31521: Configure behaviour when checking in a reserved item at SCO This patch adds a system preference (SCOCheckinIfReservedBehaviour) which allow to control the behaviour of SCO checkin when the returned item is reserved: - allow checkin (current behaviour) - allow checkin and show a message - forbid checkin and show a message The message is configurable is another system preference (SCOCheckinIfReservedMessage) Test plan: 1. Apply patch, run updatedatabase.pl and restart koha 2. Enable WebBasedSelfCheck and SCOAllowCheckin 3. (Staff) Set SCOCheckinIfReservedBehaviour to "Forbid checkin & show message" 4. (Staff) Write some text in SCOCheckinIfReservedMessage 5. (Staff) Checkout an item I to patron A 6. (Staff) Place a hold on item I for patron B 7. (SCO) Log in to SCO with patron A 8. (SCO) Try to return item I The configured message should be displayed and item I should still be checked out 9. (Staff) Set SCOCheckinIfReservedBehaviour to "Allow checkin & show message" 10. (SCO) Try to return item I The configured message should be displayed and item I should have been checked in 11. (Staff) Checkout item I to patron A again 12. (Staff) Set SCOCheckinIfReservedBehaviour to "Allow checkin" 13. (SCO) Try to return item I The configured message should NOT be displayed and item I should have been checked in
I like this but have a couple questions/comments: 1. Should 'SCOCheckinIfReservedMessage' allow the use of HTML? 2. If 'SCOCheckinIfReservedBehaviour' is set to forbid or alert should we also check for the existence of 'SCOCheckinIfReservedMessage' to avoid displaying an empty '<div class="alert alert-warning">'?
Doesn't apply cleanly anymore.
Created attachment 169820 [details] [review] Bug 31521: Configure behaviour when checking in a reserved item at SCO This patch adds a system preference (SCOCheckinIfReservedBehaviour) which allow to control the behaviour of SCO checkin when the returned item is reserved: - allow checkin (current behaviour) - allow checkin and show a message - forbid checkin and show a message The message is configurable is another system preference (SCOCheckinIfReservedMessage) Test plan: 1. Apply patch, run updatedatabase.pl and restart koha 2. Enable WebBasedSelfCheck and SCOAllowCheckin 3. (Staff) Set SCOCheckinIfReservedBehaviour to "Forbid checkin & show message" 4. (Staff) Write some text in SCOCheckinIfReservedMessage 5. (Staff) Checkout an item I to patron A 6. (Staff) Place a hold on item I for patron B 7. (SCO) Log in to SCO with patron A 8. (SCO) Try to return item I The configured message should be displayed and item I should still be checked out 9. (Staff) Set SCOCheckinIfReservedBehaviour to "Allow checkin & show message" 10. (SCO) Try to return item I The configured message should be displayed and item I should have been checked in 11. (Staff) Checkout item I to patron A again 12. (Staff) Set SCOCheckinIfReservedBehaviour to "Allow checkin" 13. (SCO) Try to return item I The configured message should NOT be displayed and item I should have been checked in
Rebased on master
Created attachment 170572 [details] [review] Bug 31521: Configure behaviour when checking in a reserved item at SCO This patch adds a system preference (SCOCheckinIfReservedBehaviour) which allow to control the behaviour of SCO checkin when the returned item is reserved: - allow checkin (current behaviour) - allow checkin and show a message - forbid checkin and show a message The message is configurable is another system preference (SCOCheckinIfReservedMessage) Test plan: 1. Apply patch, run updatedatabase.pl and restart koha 2. Enable WebBasedSelfCheck and SCOAllowCheckin 3. (Staff) Set SCOCheckinIfReservedBehaviour to "Forbid checkin & show message" 4. (Staff) Write some text in SCOCheckinIfReservedMessage 5. (Staff) Checkout an item I to patron A 6. (Staff) Place a hold on item I for patron B 7. (SCO) Log in to SCO with patron A 8. (SCO) Try to return item I The configured message should be displayed and item I should still be checked out 9. (Staff) Set SCOCheckinIfReservedBehaviour to "Allow checkin & show message" 10. (SCO) Try to return item I The configured message should be displayed and item I should have been checked in 11. (Staff) Checkout item I to patron A again 12. (Staff) Set SCOCheckinIfReservedBehaviour to "Allow checkin" 13. (SCO) Try to return item I The configured message should NOT be displayed and item I should have been checked in Signed-off-by: Sam Lau <samalau@gmail.com>