Bug 31597 - Missing semicolon after try-catch in restrictions.pl
Summary: Missing semicolon after try-catch in restrictions.pl
Status: Pushed to master
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Emmi Takkinen
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-22 06:07 UTC by Emmi Takkinen
Modified: 2022-09-22 11:25 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31597: Add missing semicolon to restriction.pl (1.02 KB, patch)
2022-09-22 06:10 UTC, Emmi Takkinen
Details | Diff | Splinter Review
Bug 31597: Add missing semicolon to restriction.pl (1.12 KB, patch)
2022-09-22 07:10 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Emmi Takkinen 2022-09-22 06:07:12 UTC
In restrictions.pl line 114 is missing a semicolon after try-catch statement. This causes error 500 when one tries to delete restriction.

To test:
1. Navigate to "Patron restrictions".
2. Find or create patron restriction to be deleted.
3. Hit "Delete" and confirm deletion.
=> Error 500 is raised.
Comment 1 Emmi Takkinen 2022-09-22 06:10:59 UTC
Created attachment 140841 [details] [review]
Bug 31597: Add missing semicolon to restriction.pl

In restrictions.pl line 114 is missing a semicolon after try-catch statement.
This causes error 500 when one tries to delete restriction.

To test:
1. Navigate to "Patron restrictions".
2. Find or create patron restriction to be deleted.
3. Hit "Delete" and confirm deletion.
=> Error 500 is raised.
4. Apply this patch.
5. Try to delete again.
=> Success!

Sponsored-by: Koha-Suomi Oy
Comment 2 Marcel de Rooy 2022-09-22 07:10:39 UTC
Created attachment 140842 [details] [review]
Bug 31597: Add missing semicolon to restriction.pl

In restrictions.pl line 114 is missing a semicolon after try-catch statement.
This causes error 500 when one tries to delete restriction.

To test:
1. Navigate to "Patron restrictions".
2. Find or create patron restriction to be deleted.
3. Hit "Delete" and confirm deletion.
=> Error 500 is raised.
4. Apply this patch.
5. Try to delete again.
=> Success!

Sponsored-by: Koha-Suomi Oy

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 3 Tomás Cohen Arazi 2022-09-22 11:25:19 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!