It can be useful to know exactly what template was used to generate a notice. To this end, it would be useful to store the letter id as a foreign key in the message queue table.
Created attachment 140996 [details] [review] Bug 31626: Add letter id to the message queue table It can be useful to know exactly what template was used to generate a notice. To this end, it would be useful to store the letter id as a foreign key in the message queue table. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Run an action that will send a notice to a patron 5) Note the letter id is now in the message_queue table for that notice!
(In reply to Kyle M Hall from comment #1) > 2) Run updatedatabase.pl It seems to be missing an atomic update file
(In reply to Owen Leonard from comment #2) > (In reply to Kyle M Hall from comment #1) > > 2) Run updatedatabase.pl > > It seems to be missing an atomic update file Thanks! Will fix!
Created attachment 140999 [details] [review] Bug 31626: Update Schema Files [DO NOT PUSH]
Created attachment 141001 [details] [review] Bug 31626: Add letter id to the message queue table It can be useful to know exactly what template was used to generate a notice. To this end, it would be useful to store the letter id as a foreign key in the message queue table. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Run an action that will send a notice to a patron 5) Note the letter id is now in the message_queue table for that notice!
Created attachment 141005 [details] [review] Bug 31626: Update Schema Files [DO NOT PUSH] Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Created attachment 141006 [details] [review] Bug 31626: Add letter id to the message queue table It can be useful to know exactly what template was used to generate a notice. To this end, it would be useful to store the letter id as a foreign key in the message queue table. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Run an action that will send a notice to a patron 5) Note the letter id is now in the message_queue table for that notice! Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
My first thought was: isn't the letter code not enough? But indeed... it isn't. we can have the same code for different branches, while it's not the same text.
Created attachment 141942 [details] [review] Bug 31626: Update Schema Files [DO NOT PUSH] Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 141943 [details] [review] Bug 31626: Add letter id to the message queue table It can be useful to know exactly what template was used to generate a notice. To this end, it would be useful to store the letter id as a foreign key in the message queue table. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Run an action that will send a notice to a patron 5) Note the letter id is now in the message_queue table for that notice! Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 142054 [details] [review] Bug 31626: (QA follow-up) Make db_rev robust Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to master for 22.11. Nice work everyone, thanks!
Enhancement will not be backported to 22.05.x series
Not sure what needs documenting, seems to be only backend stuff. Closing, but feel free to reopen with details if needed.