Bug 31672 - Remove 'Your' from tab descriptions in OPAC patron account
Summary: Remove 'Your' from tab descriptions in OPAC patron account
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2022-10-03 16:41 UTC by Katrin Fischer
Modified: 2023-12-28 20:43 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31672: Remove 'Your' from tab descriptions in OPAC patron account (7.38 KB, patch)
2022-10-03 16:51 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31672: Remove 'Your' from tab descriptions in OPAC patron account (7.44 KB, patch)
2022-10-03 16:58 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 31672: Remove 'Your' from tab descriptions in OPAC patron account (7.47 KB, patch)
2022-10-20 17:38 UTC, Lucas Gass
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-10-03 16:41:25 UTC

    
Comment 1 Katrin Fischer 2022-10-03 16:51:54 UTC
Created attachment 141281 [details] [review]
Bug 31672: Remove 'Your' from tab descriptions in OPAC patron account

I'll try to keep the test plan simple:
* Go to patron account in OPAC
* Verify that the your from the beginning of the tab
  descriptions has been removed

Bonus: This moves the Recalls history tab below the Holds history
as this is the more logical place for it.
Comment 2 Tomás Cohen Arazi 2022-10-03 16:58:16 UTC
Created attachment 141282 [details] [review]
Bug 31672: Remove 'Your' from tab descriptions in OPAC patron account

I'll try to keep the test plan simple:
* Go to patron account in OPAC
* Verify that the your from the beginning of the tab
  descriptions has been removed

Bonus: This moves the Recalls history tab below the Holds history
as this is the more logical place for it.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 3 Lucas Gass 2022-10-20 17:38:14 UTC
Created attachment 142272 [details] [review]
Bug 31672: Remove 'Your' from tab descriptions in OPAC patron account

I'll try to keep the test plan simple:
* Go to patron account in OPAC
* Verify that the your from the beginning of the tab
  descriptions has been removed

Bonus: This moves the Recalls history tab below the Holds history
as this is the more logical place for it.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 4 Tomás Cohen Arazi 2022-10-21 14:46:49 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 5 Christopher Brannon 2023-04-11 18:12:29 UTC
Usually there is an explanation for the changes.  Would you mind sharing what led to the need for this change?
Comment 6 Katrin Fischer 2023-04-11 20:26:58 UTC
I think we had talked about this one on the IRC chat. IIRC:

* It was a way to shorten the descriptions, especially for languages where the words are much longer anyway and My turns into more letters too.
* For German it also removes the problem between formal and informal translation of you (different words).
* We had agreed that it seemed uncommon given the rest of Koha's interface and comparing with other applications.
Comment 7 Christopher Brannon 2023-04-11 21:57:41 UTC
Ah!  Thank you for the clarification.  Makes sense.