Created attachment 141281 [details] [review] Bug 31672: Remove 'Your' from tab descriptions in OPAC patron account I'll try to keep the test plan simple: * Go to patron account in OPAC * Verify that the your from the beginning of the tab descriptions has been removed Bonus: This moves the Recalls history tab below the Holds history as this is the more logical place for it.
Created attachment 141282 [details] [review] Bug 31672: Remove 'Your' from tab descriptions in OPAC patron account I'll try to keep the test plan simple: * Go to patron account in OPAC * Verify that the your from the beginning of the tab descriptions has been removed Bonus: This moves the Recalls history tab below the Holds history as this is the more logical place for it. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 142272 [details] [review] Bug 31672: Remove 'Your' from tab descriptions in OPAC patron account I'll try to keep the test plan simple: * Go to patron account in OPAC * Verify that the your from the beginning of the tab descriptions has been removed Bonus: This moves the Recalls history tab below the Holds history as this is the more logical place for it. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Pushed to master for 22.11. Nice work everyone, thanks!
Usually there is an explanation for the changes. Would you mind sharing what led to the need for this change?
I think we had talked about this one on the IRC chat. IIRC: * It was a way to shorten the descriptions, especially for languages where the words are much longer anyway and My turns into more letters too. * For German it also removes the problem between formal and informal translation of you (different words). * We had agreed that it seemed uncommon given the rest of Koha's interface and comparing with other applications.
Ah! Thank you for the clarification. Makes sense.