on catalogue/detail.pl
Created attachment 142239 [details] [review] Bug 31803: "remove from cart" button displayed even if not in cart This patch modifies CSS related to the "Remove from cart" button associated with bibligraphic record views. A change in specificity of buttons made by Bug 30952 made it so that the button was no longer hidden correctly. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Locate a bibliographic record in the staff interface and view the detail page. - In the toolbar you should see an "Add to cart" button but not a "Remove from cart" button. - The buttons should correctly toggle on and off as you add and remove the title from the cart.
Created attachment 142245 [details] [review] Bug 31803: "remove from cart" button displayed even if not in cart This patch modifies CSS related to the "Remove from cart" button associated with bibligraphic record views. A change in specificity of buttons made by Bug 30952 made it so that the button was no longer hidden correctly. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Locate a bibliographic record in the staff interface and view the detail page. - In the toolbar you should see an "Add to cart" button but not a "Remove from cart" button. - The buttons should correctly toggle on and off as you add and remove the title from the cart. Signed-off-by: David Nind <david@davidnind.com>
I am going to pass this one as it's a clear bug fix, but there is a small remaining issue: When Add to cart is replaced with Remove from cart, the writing is not in line with the other options but displayed a little higher up.
Created attachment 142337 [details] [review] Bug 31803: "remove from cart" button displayed even if not in cart This patch modifies CSS related to the "Remove from cart" button associated with bibligraphic record views. A change in specificity of buttons made by Bug 30952 made it so that the button was no longer hidden correctly. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Locate a bibliographic record in the staff interface and view the detail page. - In the toolbar you should see an "Add to cart" button but not a "Remove from cart" button. - The buttons should correctly toggle on and off as you add and remove the title from the cart. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Pushed to master for 22.11. Nice work everyone, thanks!