Bug 31808 - When placing a hold patron name is not displaying correctly
Summary: When placing a hold patron name is not displaying correctly
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Lucas Gass
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 30952
Blocks:
  Show dependency treegraph
 
Reported: 2022-10-14 22:39 UTC by Lucas Gass
Modified: 2023-12-28 20:43 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Screenshot of problem (33.47 KB, image/png)
2022-10-14 22:39 UTC, Lucas Gass
Details
Bug 31808: Set fieldset.rows li width to 100% (1.11 KB, patch)
2022-10-14 23:23 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 31808: Set fieldset.rows li width to 100% (1.16 KB, patch)
2022-10-15 02:57 UTC, David Nind
Details | Diff | Splinter Review
Bug 31808: Set fieldset.rows li width to 100% (1.21 KB, patch)
2022-10-15 07:40 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2022-10-14 22:39:55 UTC
Created attachment 141908 [details]
Screenshot of problem

To recreate:

1. Find an item and try placing a hold.
2. Under 'Hold details' the first list element is the patron name, it displays far to the right in an unusual location.

( see attachment )
Comment 1 David Nind 2022-10-14 22:52:38 UTC
I can replicate this issue on current master as well.
Comment 2 Lucas Gass 2022-10-14 23:20:41 UTC
I think in our CSS for fieldset.rows we need to explicitly set the li elements width to 100%.
Comment 3 Lucas Gass 2022-10-14 23:23:57 UTC
Created attachment 141909 [details] [review]
Bug 31808: Set fieldset.rows li width to 100%

To test:
1. Find an item and try placing a hold.
2. Under 'Hold details' the first list element is the patron name, it displays far to the right in an unusual location.
3. Apply patch and regenerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface )
4. Try steps 1 & 2 again.
5. The name should display correctly.
Comment 4 David Nind 2022-10-15 02:57:36 UTC
Created attachment 141910 [details] [review]
Bug 31808: Set fieldset.rows li width to 100%

To test:
1. Find an item and try placing a hold.
2. Under 'Hold details' the first list element is the patron name, it displays far to the right in an unusual location.
3. Apply patch and regenerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface )
4. Try steps 1 & 2 again.
5. The name should display correctly.

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Katrin Fischer 2022-10-15 07:40:46 UTC
Created attachment 141912 [details] [review]
Bug 31808: Set fieldset.rows li width to 100%

To test:
1. Find an item and try placing a hold.
2. Under 'Hold details' the first list element is the patron name, it displays far to the right in an unusual location.
3. Apply patch and regenerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface )
4. Try steps 1 & 2 again.
5. The name should display correctly.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Tomás Cohen Arazi 2022-10-17 11:29:27 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!