When creating a new order with items, the item form formatting is broken. Also the statistics fields at the bottom of the form are misaligned.
... and the item list needs the page-section class.
https://snipboard.io/2k6ImK.jpg https://snipboard.io/c8AEjz.jpg
Created attachment 143137 [details] [review] Bug 31819: Fix formatting of item form in acq when ordering To test: 1. Apply patch and regenerate CSS ( yarn build ) 2. Add to order from an empty record to an order, make sure the page looks good. 3. Add to order from an existing record to an order, make sure the page looks good. 4. In neworderempty.pl add some new items to the order by clicking 'Add item'. The item lists table should now appear, confirm it looks right. 5. Save the form, ensuring everthing still works as it should.
Some comments: 1. The forms seem to be aligned to the centre of the screen, rather than left aligned. 2. Form input field widths: I think these look odd being almost all the same width, particularly on the accounting details form for fields with numbers.
Created attachment 143641 [details] Original
Hmm.. we're going in the right direction, but it still feels a bit weird.. not sure flex 25% is the way to go.. as David points out.. on a wide screen it shifts the content to look 'centered' which feels a bit strange.. I think I'd rather see a more fixed width for all the labels...
Created attachment 143669 [details] [review] Bug 31819: [alternate] Formatting of item form in acq when ordering is broken I propose that we add CSS to the page to fix this since it's fairly specific to the way this page is broken. To test, apply the patch and view a basket in Acquisitions. - Click "Add to basket" and choose "From a new (empty) record." - Confirm that the item form layout looks correct. - Perform the same test when adding to a basket from an existing record.
Created attachment 143680 [details] [review] Bug 31819: [alternate] Formatting of item form in acq when ordering is broken I propose that we add CSS to the page to fix this since it's fairly specific to the way this page is broken. To test, apply the patch and view a basket in Acquisitions. - Click "Add to basket" and choose "From a new (empty) record." - Confirm that the item form layout looks correct. - Perform the same test when adding to a basket from an existing record. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 143681 [details] [review] Bug 31819: (QA follow-up) Fix alignment of Statistic fields at end of form
Created attachment 143683 [details] [review] Bug 31819: (QA follow-up) Add page section to list of items In order to test, you need to add items on order and add at least one to make the list appear above the item section
Created attachment 143691 [details] [review] Bug 31819: [alternate] Formatting of item form in acq when ordering is broken I propose that we add CSS to the page to fix this since it's fairly specific to the way this page is broken. To test, apply the patch and view a basket in Acquisitions. - Click "Add to basket" and choose "From a new (empty) record." - Confirm that the item form layout looks correct. - Perform the same test when adding to a basket from an existing record. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 143692 [details] [review] Bug 31819: (QA follow-up) Fix alignment of Statistic fields at end of form Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 143693 [details] [review] Bug 31819: (QA follow-up) Add page section to list of items In order to test, you need to add items on order and add at least one to make the list appear above the item section Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Well.. these patches fix some things and improve some others.. I still think the page looks a bit weird but I can't really fail it for that. We can continue to refine next cycle. Passing QA
Pushed to master for 22.11. Nice work everyone, thanks!
Note that it's still messy when receiving - https://snipboard.io/FxMiK9.jpg
(In reply to Jonathan Druart from comment #16) > Note that it's still messy when receiving - https://snipboard.io/FxMiK9.jpg Filed separately as: Bug 32189 - When items are created on receive, item form layout is broken