Bug 31819 - Formatting of item form in acq when ordering is broken
Summary: Formatting of item form in acq when ordering is broken
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low major (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 30952
Blocks:
  Show dependency treegraph
 
Reported: 2022-10-16 11:05 UTC by Katrin Fischer
Modified: 2023-06-08 22:28 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31819: Fix formatting of item form in acq when ordering (3.87 KB, patch)
2022-11-03 15:46 UTC, Lucas Gass
Details | Diff | Splinter Review
Original (167.05 KB, image/png)
2022-11-10 11:25 UTC, Martin Renvoize
Details
Bug 31819: [alternate] Formatting of item form in acq when ordering is broken (1.97 KB, patch)
2022-11-10 14:47 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31819: [alternate] Formatting of item form in acq when ordering is broken (2.03 KB, patch)
2022-11-10 16:02 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31819: (QA follow-up) Fix alignment of Statistic fields at end of form (1.67 KB, patch)
2022-11-10 16:02 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31819: (QA follow-up) Add page section to list of items (1.17 KB, patch)
2022-11-10 16:09 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31819: [alternate] Formatting of item form in acq when ordering is broken (2.09 KB, patch)
2022-11-10 16:45 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 31819: (QA follow-up) Fix alignment of Statistic fields at end of form (1.73 KB, patch)
2022-11-10 16:45 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 31819: (QA follow-up) Add page section to list of items (1.24 KB, patch)
2022-11-10 16:45 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-10-16 11:05:09 UTC
When creating a new order with items, the item form formatting is broken. Also the statistics fields at the bottom of the form are misaligned.
Comment 1 Katrin Fischer 2022-10-16 11:06:14 UTC
... and the item list needs the page-section class.
Comment 3 Lucas Gass 2022-11-03 15:46:27 UTC
Created attachment 143137 [details] [review]
Bug 31819: Fix formatting of item form in acq when ordering

To test:
1. Apply patch and regenerate CSS ( yarn build )
2. Add to order from an empty record to an order, make sure the page looks good.
3. Add to order from an existing record to an order, make sure the page looks good.
4. In neworderempty.pl add some new items to the order by clicking 'Add item'. The item lists table should now appear, confirm it looks right.
5. Save the form, ensuring everthing still works as it should.
Comment 4 David Nind 2022-11-05 18:20:40 UTC
Some comments:

1. The forms seem to be aligned to the centre of the screen, rather than left aligned.

2. Form input field widths: I think these look odd being almost all the same width, particularly on the accounting details form for fields with numbers.
Comment 5 Martin Renvoize 2022-11-10 11:25:23 UTC
Created attachment 143641 [details]
Original
Comment 6 Martin Renvoize 2022-11-10 11:27:07 UTC
Hmm.. we're going in the right direction, but it still feels a bit weird.. not sure flex 25% is the way to go.. as David points out.. on a wide screen it shifts the content to look 'centered' which feels a bit strange.. I think I'd rather see a more fixed width for all the labels...
Comment 7 Owen Leonard 2022-11-10 14:47:24 UTC
Created attachment 143669 [details] [review]
Bug 31819: [alternate] Formatting of item form in acq when ordering is broken

I propose that we add CSS to the page to fix this since it's fairly
specific to the way this page is broken.

To test, apply the patch and view a basket in Acquisitions.

- Click "Add to basket" and choose "From a new (empty) record."
- Confirm that the item form layout looks correct.
- Perform the same test when adding to a basket from an existing record.
Comment 8 Katrin Fischer 2022-11-10 16:02:24 UTC
Created attachment 143680 [details] [review]
Bug 31819: [alternate] Formatting of item form in acq when ordering is broken

I propose that we add CSS to the page to fix this since it's fairly
specific to the way this page is broken.

To test, apply the patch and view a basket in Acquisitions.

- Click "Add to basket" and choose "From a new (empty) record."
- Confirm that the item form layout looks correct.
- Perform the same test when adding to a basket from an existing record.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 9 Katrin Fischer 2022-11-10 16:02:28 UTC
Created attachment 143681 [details] [review]
Bug 31819: (QA follow-up) Fix alignment of Statistic fields at end of form
Comment 10 Katrin Fischer 2022-11-10 16:09:48 UTC
Created attachment 143683 [details] [review]
Bug 31819: (QA follow-up) Add page section to list of items

In order to test, you need to add items on order and add
at least one to make the list appear above the item section
Comment 11 Martin Renvoize 2022-11-10 16:45:20 UTC
Created attachment 143691 [details] [review]
Bug 31819: [alternate] Formatting of item form in acq when ordering is broken

I propose that we add CSS to the page to fix this since it's fairly
specific to the way this page is broken.

To test, apply the patch and view a basket in Acquisitions.

- Click "Add to basket" and choose "From a new (empty) record."
- Confirm that the item form layout looks correct.
- Perform the same test when adding to a basket from an existing record.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 12 Martin Renvoize 2022-11-10 16:45:25 UTC
Created attachment 143692 [details] [review]
Bug 31819: (QA follow-up) Fix alignment of Statistic fields at end of form

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 13 Martin Renvoize 2022-11-10 16:45:30 UTC
Created attachment 143693 [details] [review]
Bug 31819: (QA follow-up) Add page section to list of items

In order to test, you need to add items on order and add
at least one to make the list appear above the item section

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 14 Martin Renvoize 2022-11-10 16:46:30 UTC
Well.. these patches fix some things and improve some others.. I still think the page looks a bit weird but I can't really fail it for that.

We can continue to refine next cycle.

Passing QA
Comment 15 Tomás Cohen Arazi 2022-11-10 17:51:31 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 16 Jonathan Druart 2022-11-11 08:41:09 UTC
Note that it's still messy when receiving - https://snipboard.io/FxMiK9.jpg
Comment 17 Katrin Fischer 2022-11-13 22:38:14 UTC
(In reply to Jonathan Druart from comment #16)
> Note that it's still messy when receiving - https://snipboard.io/FxMiK9.jpg

Filed separately as: Bug 32189 - When items are created on receive, item form layout is broken