Bug 31826 - Add page-section to item form on order receive page (acq)
Summary: Add page-section to item form on order receive page (acq)
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/acqui/orderreceive.pl?o...
Keywords:
Depends on: 30952
Blocks: 31757
  Show dependency treegraph
 
Reported: 2022-10-16 11:25 UTC by Katrin Fischer
Modified: 2023-06-08 22:28 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31826: Add page-section to item form on order receive page (acq) (1.61 KB, patch)
2022-11-09 17:17 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31826: Add page-section to item form on order receive page (acq) (1.66 KB, patch)
2022-11-09 20:57 UTC, David Nind
Details | Diff | Splinter Review
Bug 31826: Add page-section to item form on order receive page (acq) (1.71 KB, patch)
2022-11-09 23:33 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-10-16 11:25:00 UTC
When receiving an order with connected 'order items', the item table is missing the page-section and appears with grey background.
Comment 1 Owen Leonard 2022-11-09 17:17:03 UTC
Created attachment 143558 [details] [review]
Bug 31826: Add page-section to item form on order receive page (acq)

This patch adds a "page-section" class to the container div around the
items table on the order receive page in acquisitions.

To test, apply the patch and go to Acquisitions.

- Locate a vendor and few its details.
- Click "Receive shipments."
- Fill out the "Receive shipment" form if you have no existing
  shipments. Otherwise click on the invoice number link to get to the
  "Receive orders" page.
- In the table of pending orders, click a "Receive" link.
- On the "Receive items" page there should be three sections: Catalog
  details, Acquisitions details, and Items.
Comment 2 David Nind 2022-11-09 20:57:06 UTC
Created attachment 143590 [details] [review]
Bug 31826: Add page-section to item form on order receive page (acq)

This patch adds a "page-section" class to the container div around the
items table on the order receive page in acquisitions.

To test, apply the patch and go to Acquisitions.

- Locate a vendor and few its details.
- Click "Receive shipments."
- Fill out the "Receive shipment" form if you have no existing
  shipments. Otherwise click on the invoice number link to get to the
  "Receive orders" page.
- In the table of pending orders, click a "Receive" link.
- On the "Receive items" page there should be three sections: Catalog
  details, Acquisitions details, and Items.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2022-11-09 23:33:01 UTC
Created attachment 143602 [details] [review]
Bug 31826: Add page-section to item form on order receive page (acq)

This patch adds a "page-section" class to the container div around the
items table on the order receive page in acquisitions.

To test, apply the patch and go to Acquisitions.

- Locate a vendor and few its details.
- Click "Receive shipments."
- Fill out the "Receive shipment" form if you have no existing
  shipments. Otherwise click on the invoice number link to get to the
  "Receive orders" page.
- In the table of pending orders, click a "Receive" link.
- On the "Receive items" page there should be three sections: Catalog
  details, Acquisitions details, and Items.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2022-11-10 13:06:07 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!