Bug 31830 - Add page-section to budgets and funds table on acq start page (acq)
Summary: Add page-section to budgets and funds table on acq start page (acq)
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Lucas Gass
QA Contact: Katrin Fischer
URL: /cgi-bin/koha/acqui/acqui-home.pl
Keywords:
Depends on: 30952
Blocks: 31757
  Show dependency treegraph
 
Reported: 2022-10-16 12:02 UTC by Katrin Fischer
Modified: 2023-12-28 20:43 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31830: Add page-section class to acq home table (12.38 KB, patch)
2022-10-19 22:55 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 31830: Add page-section class to acq home table (12.43 KB, patch)
2022-10-20 08:54 UTC, David Nind
Details | Diff | Splinter Review
Bug 31830: Add page-section class to acq home table (12.48 KB, patch)
2022-10-21 13:42 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31830: (QA follow-up) include heading in page section (1.48 KB, patch)
2022-10-21 13:42 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-10-16 12:02:49 UTC
The budget and funds table on the acq start page should have a page-section class.
Comment 1 Lucas Gass 2022-10-19 22:55:37 UTC
Created attachment 142216 [details] [review]
Bug 31830: Add page-section class to acq home table

To test:
1. Go to the Acquisitions home page.
2. Look and the bugdets and funds table and notice the page-section class.
3. Make sure everything looks good.

Note: I made some indentation changes.
Comment 2 David Nind 2022-10-20 08:54:16 UTC
Created attachment 142233 [details] [review]
Bug 31830: Add page-section class to acq home table

To test:
1. Go to the Acquisitions home page.
2. Look and the bugdets and funds table and notice the page-section class.
3. Make sure everything looks good.

Note: I made some indentation changes.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2022-10-21 13:42:12 UTC
Created attachment 142391 [details] [review]
Bug 31830: Add page-section class to acq home table

To test:
1. Go to the Acquisitions home page.
2. Look and the bugdets and funds table and notice the page-section class.
3. Make sure everything looks good.

Note: I made some indentation changes.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 4 Katrin Fischer 2022-10-21 13:42:16 UTC
Created attachment 142392 [details] [review]
Bug 31830: (QA follow-up) include heading in page section

Moves the div up a few levels to the heading for this part of the page
is included. This also makes it consistent with the page-section for
"Manage orders" directly above.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 5 Tomás Cohen Arazi 2022-10-21 14:47:21 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!