info coming...
Created attachment 142218 [details] [review] Bug 31883: t::lib::QA::TemplateFilters missing built-in TT filter "trim" causes false warnings to test... 1/ checkout latest master 2/ prove xt/find-missing-filters.t xt/find-missing-filters.t .. 1/1 # Failed test 'Template variables should be correctly escaped' # at xt/find-missing-filters.t line 59. # got: '1' # expected: '0' # $VAR1 = { # 'errors' => [ # { # 'error' => 'missing_filter', # 'line' => ' [% messages = INCLUDE \'patron_messages.inc\' moremember = 1 | trim %]', # 'line_number' => 97 # } # ], # 'file' => 'koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt' # }; # Looks like you failed 1 test of 1. 3/ apply patch 4/ prove xt/find-missing-filters.t xt/find-missing-filters.t .. ok All tests successful. Files=1, Tests=1, 2 wallclock secs ( 0.03 usr 0.01 sys + 2.15 cusr 0.07 csys = 2.26 CPU) Result: PASS <<<<<<<<<<<<<<<
Mason, thanks for the patch! I thought of a similar patch, but kept thinking a variable assignment shouldn't be forced to have a filter, and so was in doubt about it. I'm happy to go with this regardless.
I followed the test plan and everything works. For some reason I can't sign off like I normally do (git bz attach -e 31883 HEAD).
I can sign off other bugs, so maybe something wrong with this one? This is the message I'm getting when I go git bz attach -e 31883 HEAD (after a git so 1): git bz attach -e 31883 HEAD /usr/bin/git-bz:1908: UnicodeWarning: Unicode equal comparison failed to convert both arguments to Unicode - interpreting them as being unequal obsoleted = (initial_description == patch.description) Traceback (most recent call last): File "/usr/bin/git-bz", line 2722, in <module> do_attach(*args) File "/usr/bin/git-bz", line 2074, in do_attach attach_commits(bug, commits, edit_comments=global_options.edit) File "/usr/bin/git-bz", line 1988, in attach_commits description, body, obsoletes, statuses, patch_complexities, depends = edit_attachment_comment(bug, commit.subject, body) File "/usr/bin/git-bz", line 1940, in edit_attachment_comment lines = edit_template(template.getvalue()) File "/usr/lib/python2.7/StringIO.py", line 271, in getvalue self.buf += ''.join(self.buflist) UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 3: ordinal not in range(128)
Same here UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 3: ordinal not in range(128) Will edit commit message now.
Lowering severity. Critical is really another category :)
Not sure whats going on here. Please resubmit a new version.
It seems to be another general issue?
(In reply to Marcel de Rooy from comment #8) > It seems to be another general issue? No. I refreshed my container. Could git attach again. But after applying this patch, we see our friend again: /usr/local/bin/git-bz:1908: UnicodeWarning: Unicode equal comparison failed to convert both arguments to Unicode - interpreting them as being unequal obsoleted = (initial_description == patch.description) Traceback (most recent call last): File "/usr/local/bin/git-bz", line 2722, in <module> do_attach(*args) File "/usr/local/bin/git-bz", line 2074, in do_attach attach_commits(bug, commits, edit_comments=global_options.edit) File "/usr/local/bin/git-bz", line 1988, in attach_commits description, body, obsoletes, statuses, patch_complexities, depends = edit_attachment_comment(bug, commit.subject, body) File "/usr/local/bin/git-bz", line 1940, in edit_attachment_comment lines = edit_template(template.getvalue()) File "/usr/lib/python2.7/StringIO.py", line 271, in getvalue self.buf += ''.join(self.buflist) UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 3: ordinal not in range(128)
Comment on attachment 142218 [details] [review] Bug 31883: t::lib::QA::TemplateFilters missing built-in TT filter "trim" causes false warnings Ttile of bug report and attachment name cause(d) Unicode issues
Created attachment 142235 [details] [review] Filter trim causes false warnings
Created attachment 142236 [details] [review] Bug 31883: t::lib::QA::TemplateFilters missing built-in TT filter "trim" causes false warnings to test... 1/ checkout latest master 2/ prove xt/find-missing-filters.t xt/find-missing-filters.t .. 1/1 # Failed test 'Template variables should be correctly escaped' # at xt/find-missing-filters.t line 59. # got: '1' # expected: '0' # $VAR1 = { # 'errors' => [ # { # 'error' => 'missing_filter', # 'line' => ' [% messages = INCLUDE \'patron_messages.inc\' moremember = 1 | trim %]', # 'line_number' => 97 # } # ], # 'file' => 'koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt' # }; # Looks like you failed 1 test of 1. 3/ apply patch 4/ prove xt/find-missing-filters.t xt/find-missing-filters.t .. ok All tests successful. Files=1, Tests=1, 2 wallclock secs ( 0.03 usr 0.01 sys + 2.15 cusr 0.07 csys = 2.26 CPU) Result: PASS <<<<<<<<<<<<<<< Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 142237 [details] [review] Bug 31883: Filter trim causes false warnings Test plan: Run xt/find-missing-filters.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 142238 [details] [review] Bug 31883: Filter trim causes false warnings Test plan: Run xt/find-missing-filters.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Pushed to master for 22.11. Nice work everyone, thanks!
Backported to 22.05.x for upcoming 22.05.08
applied to 21.11 for 21.11.15
Not backported to 21.05.x