The buttons on the reserves/request.pl page have no spacing between them.
Created attachment 142315 [details] Example
Also, ater the page section is fixed, the background for the row/line with the buttons is a light grey. See the screenshots attached to bug 31806.
Created attachment 142667 [details] [review] Bug 31905: Fix button spacing on holds page This patch makes minor modifications to the holds template in order to improve the display of the hold buttons related to existing holds. The patch also adds "display:none" to the hold cancellation fieldset so there isn't a flash of content before JavaScript hides it. To test, apply the patch and locate a record in the catalog. - Place one or more holds on the record. - View the holds for that record. - Under the "Existing holds" heading there should be a toolbar of buttons which sits above the page-section div. The buttons should be well spaced. - If you have cancellation reasons defined in authorized values, the "Cancel selected" button should correctly trigger a modal with the option to specify a cancellation reason. - The display should work well for any setting of the HoldsSplitQueue system preference.
Created attachment 142670 [details] [review] Bug 31905: Fix button spacing on holds page This patch makes minor modifications to the holds template in order to improve the display of the hold buttons related to existing holds. The patch also adds "display:none" to the hold cancellation fieldset so there isn't a flash of content before JavaScript hides it. To test, apply the patch and locate a record in the catalog. - Place one or more holds on the record. - View the holds for that record. - Under the "Existing holds" heading there should be a toolbar of buttons which sits above the page-section div. The buttons should be well spaced. - If you have cancellation reasons defined in authorized values, the "Cancel selected" button should correctly trigger a modal with the option to specify a cancellation reason. - The display should work well for any setting of the HoldsSplitQueue system preference. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 142689 [details] [review] Bug 31905: Fix button spacing on holds page This patch makes minor modifications to the holds template in order to improve the display of the hold buttons related to existing holds. The patch also adds "display:none" to the hold cancellation fieldset so there isn't a flash of content before JavaScript hides it. To test, apply the patch and locate a record in the catalog. - Place one or more holds on the record. - View the holds for that record. - Under the "Existing holds" heading there should be a toolbar of buttons which sits above the page-section div. The buttons should be well spaced. - If you have cancellation reasons defined in authorized values, the "Cancel selected" button should correctly trigger a modal with the option to specify a cancellation reason. - The display should work well for any setting of the HoldsSplitQueue system preference. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 22.11. Nice work everyone, thanks!