Bug 31905 - Buttons lack spacing on holds
Summary: Buttons lack spacing on holds
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 31806
Blocks:
  Show dependency treegraph
 
Reported: 2022-10-21 09:49 UTC by Martin Renvoize
Modified: 2023-12-28 20:43 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Example (9.95 KB, image/png)
2022-10-21 09:49 UTC, Martin Renvoize
Details
Bug 31905: Fix button spacing on holds page (2.96 KB, patch)
2022-10-26 11:34 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31905: Fix button spacing on holds page (3.01 KB, patch)
2022-10-26 12:53 UTC, David Nind
Details | Diff | Splinter Review
Bug 31905: Fix button spacing on holds page (3.06 KB, patch)
2022-10-26 21:52 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2022-10-21 09:49:06 UTC
The buttons on the reserves/request.pl page have no spacing between them.
Comment 1 Martin Renvoize 2022-10-21 09:49:24 UTC
Created attachment 142315 [details]
Example
Comment 2 David Nind 2022-10-23 22:59:56 UTC
Also, ater the page section is fixed, the background for the row/line with the buttons is a light grey.

See the screenshots attached to bug 31806.
Comment 3 Owen Leonard 2022-10-26 11:34:02 UTC
Created attachment 142667 [details] [review]
Bug 31905: Fix button spacing on holds page

This patch makes minor modifications to the holds template in order to
improve the display of the hold buttons related to existing holds.

The patch also adds "display:none" to the hold cancellation fieldset so
there isn't a flash of content before JavaScript hides it.

To test, apply the patch and locate a record in the catalog.

- Place one or more holds on the record.
- View the holds for that record.
- Under the "Existing holds" heading there should be a toolbar of
  buttons which sits above the page-section div. The buttons should be
  well spaced.
- If you have cancellation reasons defined in authorized values, the
  "Cancel selected" button should correctly trigger a modal with the
  option to specify a cancellation reason.
- The display should work well for any setting of the HoldsSplitQueue
  system preference.
Comment 4 David Nind 2022-10-26 12:53:08 UTC
Created attachment 142670 [details] [review]
Bug 31905: Fix button spacing on holds page

This patch makes minor modifications to the holds template in order to
improve the display of the hold buttons related to existing holds.

The patch also adds "display:none" to the hold cancellation fieldset so
there isn't a flash of content before JavaScript hides it.

To test, apply the patch and locate a record in the catalog.

- Place one or more holds on the record.
- View the holds for that record.
- Under the "Existing holds" heading there should be a toolbar of
  buttons which sits above the page-section div. The buttons should be
  well spaced.
- If you have cancellation reasons defined in authorized values, the
  "Cancel selected" button should correctly trigger a modal with the
  option to specify a cancellation reason.
- The display should work well for any setting of the HoldsSplitQueue
  system preference.

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Katrin Fischer 2022-10-26 21:52:25 UTC
Created attachment 142689 [details] [review]
Bug 31905: Fix button spacing on holds page

This patch makes minor modifications to the holds template in order to
improve the display of the hold buttons related to existing holds.

The patch also adds "display:none" to the hold cancellation fieldset so
there isn't a flash of content before JavaScript hides it.

To test, apply the patch and locate a record in the catalog.

- Place one or more holds on the record.
- View the holds for that record.
- Under the "Existing holds" heading there should be a toolbar of
  buttons which sits above the page-section div. The buttons should be
  well spaced.
- If you have cancellation reasons defined in authorized values, the
  "Cancel selected" button should correctly trigger a modal with the
  option to specify a cancellation reason.
- The display should work well for any setting of the HoldsSplitQueue
  system preference.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Tomás Cohen Arazi 2022-10-27 12:44:35 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!