when I am on acqui-home.pl, the nav menu is showing the item hovered by the pointer with a nice green label on the left of the element, and changing its background. However the behaviour in the "More" dropdown menu is to simply underline the selected items.
Created attachment 142709 [details] [review] Bug 31919: Add background-color to a:hover in the header
Like that?
Created attachment 142755 [details] [review] Bug 31919: Add background-color to a:hover in the header Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
I like it I think.. though I'm not 100% on the bottom marging staying black.. Signing off, but other opinions are welcome.
Please don't forget to set assignee!
Created attachment 142810 [details] [review] Bug 31919: Add background-color to a:hover in the header Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I like that this makes it easier visible what you have selected. Love it on the pull downs, not completely sure about the menu items. But I think it's better than the underline that is not as visible by far.
(In reply to Katrin Fischer from comment #5) > Please don't forget to set assignee! It was not a clean patch (it was not NSO) and hadn't more time to spend on this, it was only a suggestion patch and didn't set the assignee on purpose ;)
I would wait for Owen's opinion before pushing this.
Created attachment 142828 [details] [review] Bug 31919: [alternate] Add backgground color to hovered items in header dropdowns This alternate patch is different in a few ways: - Add a hover background color only to items in dropdown menus. - Use an SCSS variable for the background color - Update the specificity of the hover CSS to more fully override Bootstrap's default. To test, apply the patch and rebuild the staff interface CSS. - On any page in the staff interface, test the behavior of links in the nav header. - The always-visible links (Circulation, Patrons, etc) should keep the same style as before: Underline on hover. - In dropdown menus like "More" and the user menu in the upper right corner, hovered links should have a green background.
The behaviour of the background-color for the "Search bottom array" is really weird. But it's not coming from this patch I think. Could you have a look?
Created attachment 142831 [details] [review] Bug 31919: Add backgground color to hovered items in header dropdowns This alternate patch is different in a few ways: - Add a hover background color only to items in dropdown menus. - Use an SCSS variable for the background color - Update the specificity of the hover CSS to more fully override Bootstrap's default. To test, apply the patch and rebuild the staff interface CSS. - On any page in the staff interface, test the behavior of links in the nav header. - The always-visible links (Circulation, Patrons, etc) should keep the same style as before: Underline on hover. - In dropdown menus like "More" and the user menu in the upper right corner, hovered links should have a green background. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 142893 [details] [review] Bug 31919: Add backgground color to hovered items in header dropdowns This alternate patch is different in a few ways: - Add a hover background color only to items in dropdown menus. - Use an SCSS variable for the background color - Update the specificity of the hover CSS to more fully override Bootstrap's default. To test, apply the patch and rebuild the staff interface CSS. - On any page in the staff interface, test the behavior of links in the nav header. - The always-visible links (Circulation, Patrons, etc) should keep the same style as before: Underline on hover. - In dropdown menus like "More" and the user menu in the upper right corner, hovered links should have a green background. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 22.11. Nice work everyone, thanks!