The cn_browser.pl value builder uses a pop-up window with a big table inside. the page section would help here with it's white background color.
Created attachment 143582 [details] [review] Bug 31928: Add page-section to callnumber browser value builder (cat) This patch adds a page-section div around the search results shown by the call number browser plugin in Cataloging. The patch also restructures the search form so that the layout is correct. To test you must have an item subfield linked to the call number browser plugin: - Go to MARC frameworks -> Default MARC framework -> MARC structure. - Locate the 952 tag and click Actions -> Edit subfields. - Open the "o" tab and in the last section, "Other options," choose "cn_browser.pl" for the plugin field. Open an item record for editing: - Go to Cataloging and search for a bibliographic record. - Click Actions -> Add/Edit items for one of the results. - In the item edit form, the "o - Full call number" field should have a "..." link at the end. - Clicking it should trigger a popup window. - The search form at the top should be laid out correctly. - Perform a search which will return results. - The table of results should be contained within a white box.
Created attachment 143594 [details] [review] Bug 31928: Add page-section to callnumber browser value builder (cat) This patch adds a page-section div around the search results shown by the call number browser plugin in Cataloging. The patch also restructures the search form so that the layout is correct. To test you must have an item subfield linked to the call number browser plugin: - Go to MARC frameworks -> Default MARC framework -> MARC structure. - Locate the 952 tag and click Actions -> Edit subfields. - Open the "o" tab and in the last section, "Other options," choose "cn_browser.pl" for the plugin field. Open an item record for editing: - Go to Cataloging and search for a bibliographic record. - Click Actions -> Add/Edit items for one of the results. - In the item edit form, the "o - Full call number" field should have a "..." link at the end. - Clicking it should trigger a popup window. - The search form at the top should be laid out correctly. - Perform a search which will return results. - The table of results should be contained within a white box. Signed-off-by: David Nind <david@davidnind.com>
I noticed some "weird" behaviour with the results section: - The first time you search (for example, "a"), there is a darker green line under the column headers - If you then search for something else (for example, "s") the dark green line moves to the bottom - Repeat searching for different terms, and the green line swaps about - If there is more than one result (I added some call numebrs to items), it does the same I'm not familiar with searching using the value builder, so it may be a feature - particularly where all items have call numbers (as there are not many in the same data).
Created attachment 143606 [details] [review] Bug 31928: Add page-section to callnumber browser value builder (cat) This patch adds a page-section div around the search results shown by the call number browser plugin in Cataloging. The patch also restructures the search form so that the layout is correct. To test you must have an item subfield linked to the call number browser plugin: - Go to MARC frameworks -> Default MARC framework -> MARC structure. - Locate the 952 tag and click Actions -> Edit subfields. - Open the "o" tab and in the last section, "Other options," choose "cn_browser.pl" for the plugin field. Open an item record for editing: - Go to Cataloging and search for a bibliographic record. - Click Actions -> Add/Edit items for one of the results. - In the item edit form, the "o - Full call number" field should have a "..." link at the end. - Clicking it should trigger a popup window. - The search form at the top should be laid out correctly. - Perform a search which will return results. - The table of results should be contained within a white box. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 22.11. Nice work everyone, thanks!