Bug 31960 - Information on job detail view is misaligned
Summary: Information on job detail view is misaligned
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 30952
Blocks:
  Show dependency treegraph
 
Reported: 2022-10-24 18:59 UTC by Katrin Fischer
Modified: 2023-12-28 20:42 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Job detail for a staged MARC import (84.38 KB, image/png)
2022-10-24 18:59 UTC, Katrin Fischer
Details
Bug 31960: Information on job detail view is misaligned (6.21 KB, patch)
2022-10-25 12:07 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31960: Information on job detail view is misaligned (6.27 KB, patch)
2022-10-25 15:20 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 31960: Information on job detail view is misaligned (6.27 KB, patch)
2022-11-01 12:18 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31960: (follow-up) Make headings match (1018 bytes, patch)
2022-11-01 12:19 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31960: Information on job detail view is misaligned (6.32 KB, patch)
2022-11-01 15:03 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31960: (follow-up) Make headings match (1.05 KB, patch)
2022-11-01 15:03 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-10-24 18:59:39 UTC
Created attachment 142553 [details]
Job detail for a staged MARC import

Not sure if this applies to all different jobs, but it does to the stage MARC one. (see screneshot)

The heading is floating to the right and the other information is too far on the left.
Comment 1 Lucas Gass 2022-10-24 22:02:55 UTC
It is likely happening with other jobs. The problem lines are these ones:

            <li><label for="job_data">Report: </label>
                [% IF job.status != 'new' %][% PROCESS 'report' %][% END %]
            </li>
            <li><label for="job_data">Detailed messages: </label>
                [% IF job.status != 'new' %][% PROCESS 'detail' %][% END %]
            </li>



We are processing those blocks inside of a list element and those blocks contain a bunch of their own HTML, including h2 and h3.
Comment 2 Owen Leonard 2022-10-25 12:07:30 UTC
Created attachment 142608 [details] [review]
Bug 31960: Information on job detail view is misaligned

This patch updates the structure of the background jobs template so that
HTML processed in the report includes is well styled. The patch does
this by breaking the report and detail includes out of the fieldset and
putting them in a separate section.

This patch also adds the page-section class to the table view of current
and past background jobs.

Note: The patch includes indentation changes, so please ignore
whitespace when viewing the diff.

To test, apply the patch and go to Administration -> Manage jobs.

- The table of jobs (even if empty) should be contained in a
  page-section style white box.
- Test various processes which trigger a backgroud job:
  - Batch item modification
  - Batch item deletion
  - Batch hold deletion
  - Batch record modification
  ... etc.
- After each process has been started, view the details of the job.
- The information about the job shold be displayed well, with separate
  sections for "Report" and "Detailed messages."
Comment 3 Lucas Gass 2022-10-25 15:20:48 UTC
Created attachment 142614 [details] [review]
Bug 31960: Information on job detail view is misaligned

This patch updates the structure of the background jobs template so that
HTML processed in the report includes is well styled. The patch does
this by breaking the report and detail includes out of the fieldset and
putting them in a separate section.

This patch also adds the page-section class to the table view of current
and past background jobs.

Note: The patch includes indentation changes, so please ignore
whitespace when viewing the diff.

To test, apply the patch and go to Administration -> Manage jobs.

- The table of jobs (even if empty) should be contained in a
  page-section style white box.
- Test various processes which trigger a backgroud job:
  - Batch item modification
  - Batch item deletion
  - Batch hold deletion
  - Batch record modification
  ... etc.
- After each process has been started, view the details of the job.
- The information about the job shold be displayed well, with separate
  sections for "Report" and "Detailed messages."

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 4 Jonathan Druart 2022-10-27 10:57:19 UTC
"Report" is h2 and "Detailed messages: is h3, expected?

https://snipboard.io/VYtawT.jpg

As well as the : vs none?
Comment 5 Katrin Fischer 2022-10-27 19:05:23 UTC
I am wondering the same as Jonathan actually. Also: Detailed Messages shows with nothing below. Could we maybe only display the block if there is something to display? I noticed this after staging an import.
Comment 6 Owen Leonard 2022-11-01 12:18:59 UTC
Created attachment 142863 [details] [review]
Bug 31960: Information on job detail view is misaligned

This patch updates the structure of the background jobs template so that
HTML processed in the report includes is well styled. The patch does
this by breaking the report and detail includes out of the fieldset and
putting them in a separate section.

This patch also adds the page-section class to the table view of current
and past background jobs.

Note: The patch includes indentation changes, so please ignore
whitespace when viewing the diff.

To test, apply the patch and go to Administration -> Manage jobs.

- The table of jobs (even if empty) should be contained in a
  page-section style white box.
- Test various processes which trigger a backgroud job:
  - Batch item modification
  - Batch item deletion
  - Batch hold deletion
  - Batch record modification
  ... etc.
- After each process has been started, view the details of the job.
- The information about the job shold be displayed well, with separate
  sections for "Report" and "Detailed messages."

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 7 Owen Leonard 2022-11-01 12:19:04 UTC
Created attachment 142864 [details] [review]
Bug 31960: (follow-up) Make headings match
Comment 8 Katrin Fischer 2022-11-01 15:03:24 UTC
Created attachment 142891 [details] [review]
Bug 31960: Information on job detail view is misaligned

This patch updates the structure of the background jobs template so that
HTML processed in the report includes is well styled. The patch does
this by breaking the report and detail includes out of the fieldset and
putting them in a separate section.

This patch also adds the page-section class to the table view of current
and past background jobs.

Note: The patch includes indentation changes, so please ignore
whitespace when viewing the diff.

To test, apply the patch and go to Administration -> Manage jobs.

- The table of jobs (even if empty) should be contained in a
  page-section style white box.
- Test various processes which trigger a backgroud job:
  - Batch item modification
  - Batch item deletion
  - Batch hold deletion
  - Batch record modification
  ... etc.
- After each process has been started, view the details of the job.
- The information about the job shold be displayed well, with separate
  sections for "Report" and "Detailed messages."

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 9 Katrin Fischer 2022-11-01 15:03:29 UTC
Created attachment 142892 [details] [review]
Bug 31960: (follow-up) Make headings match

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 10 Tomás Cohen Arazi 2022-11-03 12:05:39 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!