Created attachment 142553 [details] Job detail for a staged MARC import Not sure if this applies to all different jobs, but it does to the stage MARC one. (see screneshot) The heading is floating to the right and the other information is too far on the left.
It is likely happening with other jobs. The problem lines are these ones: <li><label for="job_data">Report: </label> [% IF job.status != 'new' %][% PROCESS 'report' %][% END %] </li> <li><label for="job_data">Detailed messages: </label> [% IF job.status != 'new' %][% PROCESS 'detail' %][% END %] </li> We are processing those blocks inside of a list element and those blocks contain a bunch of their own HTML, including h2 and h3.
Created attachment 142608 [details] [review] Bug 31960: Information on job detail view is misaligned This patch updates the structure of the background jobs template so that HTML processed in the report includes is well styled. The patch does this by breaking the report and detail includes out of the fieldset and putting them in a separate section. This patch also adds the page-section class to the table view of current and past background jobs. Note: The patch includes indentation changes, so please ignore whitespace when viewing the diff. To test, apply the patch and go to Administration -> Manage jobs. - The table of jobs (even if empty) should be contained in a page-section style white box. - Test various processes which trigger a backgroud job: - Batch item modification - Batch item deletion - Batch hold deletion - Batch record modification ... etc. - After each process has been started, view the details of the job. - The information about the job shold be displayed well, with separate sections for "Report" and "Detailed messages."
Created attachment 142614 [details] [review] Bug 31960: Information on job detail view is misaligned This patch updates the structure of the background jobs template so that HTML processed in the report includes is well styled. The patch does this by breaking the report and detail includes out of the fieldset and putting them in a separate section. This patch also adds the page-section class to the table view of current and past background jobs. Note: The patch includes indentation changes, so please ignore whitespace when viewing the diff. To test, apply the patch and go to Administration -> Manage jobs. - The table of jobs (even if empty) should be contained in a page-section style white box. - Test various processes which trigger a backgroud job: - Batch item modification - Batch item deletion - Batch hold deletion - Batch record modification ... etc. - After each process has been started, view the details of the job. - The information about the job shold be displayed well, with separate sections for "Report" and "Detailed messages." Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
"Report" is h2 and "Detailed messages: is h3, expected? https://snipboard.io/VYtawT.jpg As well as the : vs none?
I am wondering the same as Jonathan actually. Also: Detailed Messages shows with nothing below. Could we maybe only display the block if there is something to display? I noticed this after staging an import.
Created attachment 142863 [details] [review] Bug 31960: Information on job detail view is misaligned This patch updates the structure of the background jobs template so that HTML processed in the report includes is well styled. The patch does this by breaking the report and detail includes out of the fieldset and putting them in a separate section. This patch also adds the page-section class to the table view of current and past background jobs. Note: The patch includes indentation changes, so please ignore whitespace when viewing the diff. To test, apply the patch and go to Administration -> Manage jobs. - The table of jobs (even if empty) should be contained in a page-section style white box. - Test various processes which trigger a backgroud job: - Batch item modification - Batch item deletion - Batch hold deletion - Batch record modification ... etc. - After each process has been started, view the details of the job. - The information about the job shold be displayed well, with separate sections for "Report" and "Detailed messages." Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 142864 [details] [review] Bug 31960: (follow-up) Make headings match
Created attachment 142891 [details] [review] Bug 31960: Information on job detail view is misaligned This patch updates the structure of the background jobs template so that HTML processed in the report includes is well styled. The patch does this by breaking the report and detail includes out of the fieldset and putting them in a separate section. This patch also adds the page-section class to the table view of current and past background jobs. Note: The patch includes indentation changes, so please ignore whitespace when viewing the diff. To test, apply the patch and go to Administration -> Manage jobs. - The table of jobs (even if empty) should be contained in a page-section style white box. - Test various processes which trigger a backgroud job: - Batch item modification - Batch item deletion - Batch hold deletion - Batch record modification ... etc. - After each process has been started, view the details of the job. - The information about the job shold be displayed well, with separate sections for "Report" and "Detailed messages." Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 142892 [details] [review] Bug 31960: (follow-up) Make headings match Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 22.11. Nice work everyone, thanks!