We use <div class="dialog message"> for informational alerts, for instance to inform the user of some kind of successful action or to provide information. In the redesign, these .message alerts have a white background, making them hard to see and not much different than the standard page-section. I think we should restore the old background color.
Created attachment 142615 [details] [review] Bug 31973: Restore background color to message-style alerts This patch restores the background color to message-style alerts, those which use the markup <div class="dialog message">. These alerts should stand out more to the user. To test, apply the patch and rebuild the staff interface CSS. - Test areas which use the message-style dialog. Perhaps the easiest example is to try to view a bibliographic record which doesn't exist: /cgi-bin/koha/catalogue/detail.pl?biblionumber=1234567890 - It can also be found as a confirmation when deleting a basket in Acquisitions, deleting a patron attribute type in Administration, updating a Z39.50 server in Administration, etc. - Confirm that the alert looks correct and is suitable visible.
Created attachment 142656 [details] [review] Bug 31973: Restore background color to message-style alerts This patch restores the background color to message-style alerts, those which use the markup <div class="dialog message">. These alerts should stand out more to the user. To test, apply the patch and rebuild the staff interface CSS. - Test areas which use the message-style dialog. Perhaps the easiest example is to try to view a bibliographic record which doesn't exist: /cgi-bin/koha/catalogue/detail.pl?biblionumber=1234567890 - It can also be found as a confirmation when deleting a basket in Acquisitions, deleting a patron attribute type in Administration, updating a Z39.50 server in Administration, etc. - Confirm that the alert looks correct and is suitable visible. Signed-off-by: David Nind <david@davidnind.com>
I think having some notes about the different classes for those dialogs would be a great addition to the style guide in the works.
There is also an instance on the transport cost matrix page if you haven't turned on the system preference activating the feature.
Created attachment 142683 [details] [review] Bug 31973: Restore background color to message-style alerts This patch restores the background color to message-style alerts, those which use the markup <div class="dialog message">. These alerts should stand out more to the user. To test, apply the patch and rebuild the staff interface CSS. - Test areas which use the message-style dialog. Perhaps the easiest example is to try to view a bibliographic record which doesn't exist: /cgi-bin/koha/catalogue/detail.pl?biblionumber=1234567890 - It can also be found as a confirmation when deleting a basket in Acquisitions, deleting a patron attribute type in Administration, updating a Z39.50 server in Administration, etc. - Confirm that the alert looks correct and is suitable visible. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 22.11. Nice work everyone, thanks!
Thanks!