Bug 31973 - Restore background color to message-style alerts
Summary: Restore background color to message-style alerts
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 30952
Blocks: 31996
  Show dependency treegraph
 
Reported: 2022-10-25 15:29 UTC by Owen Leonard
Modified: 2023-12-28 20:43 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31973: Restore background color to message-style alerts (1.82 KB, patch)
2022-10-25 15:41 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31973: Restore background color to message-style alerts (1.87 KB, patch)
2022-10-25 20:43 UTC, David Nind
Details | Diff | Splinter Review
Bug 31973: Restore background color to message-style alerts (1.93 KB, patch)
2022-10-26 20:29 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2022-10-25 15:29:37 UTC
We use <div class="dialog message"> for informational alerts, for instance to inform the user of some kind of successful action or to provide information.

In the redesign, these .message alerts have a white background, making them hard to see and not much different than the standard page-section. I think we should restore the old background color.
Comment 1 Owen Leonard 2022-10-25 15:41:39 UTC Comment hidden (obsolete)
Comment 2 David Nind 2022-10-25 20:43:31 UTC
Created attachment 142656 [details] [review]
Bug 31973: Restore background color to message-style alerts

This patch restores the background color to message-style alerts, those
which use the markup <div class="dialog message">. These alerts should
stand out more to the user.

To test, apply the patch and rebuild the staff interface CSS.

- Test areas which use the message-style dialog. Perhaps the easiest
  example is to try to view a bibliographic record which doesn't exist:

  /cgi-bin/koha/catalogue/detail.pl?biblionumber=1234567890

- It can also be found as a confirmation when deleting a basket in
  Acquisitions, deleting a patron attribute type in Administration,
  updating a Z39.50 server in Administration, etc.

- Confirm that the alert looks correct and is suitable visible.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2022-10-26 20:25:13 UTC
I think having some notes about the different classes for those dialogs would be a great addition to the style guide in the works.
Comment 4 Katrin Fischer 2022-10-26 20:28:27 UTC
There is also an instance on the transport cost matrix page if you haven't turned on the system preference activating the feature.
Comment 5 Katrin Fischer 2022-10-26 20:29:26 UTC
Created attachment 142683 [details] [review]
Bug 31973: Restore background color to message-style alerts

This patch restores the background color to message-style alerts, those
which use the markup <div class="dialog message">. These alerts should
stand out more to the user.

To test, apply the patch and rebuild the staff interface CSS.

- Test areas which use the message-style dialog. Perhaps the easiest
  example is to try to view a bibliographic record which doesn't exist:

  /cgi-bin/koha/catalogue/detail.pl?biblionumber=1234567890

- It can also be found as a confirmation when deleting a basket in
  Acquisitions, deleting a patron attribute type in Administration,
  updating a Z39.50 server in Administration, etc.

- Confirm that the alert looks correct and is suitable visible.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Tomás Cohen Arazi 2022-10-27 12:45:00 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 7 Jonathan Druart 2022-10-28 05:25:04 UTC
Thanks!