The CSS change Bug 31813 resulted in the white-space property of header search labels being overridden. We need to make sure the header search labels do not wrap.
Created attachment 142629 [details] [review] Bug 31974: Regression: Bug 31813 incorrectly affected labels in the header search This patch adds a specific white-space property to header search labels so that they do not wrap. The change made by Bug 31813 overrode the white-space property incorrectly. To test, apply the patch and rebuild the staff interface CSS. - Go to Administration. - The header search label "Search system preferences" should appear on one line. - Check that labels still wrap correctly on pages like the patron edit screen and the staged MARC record detail view. https://bugs.koha-community.org/show_bug.cgi?id=31794
Created attachment 142654 [details] [review] Bug 31974: Regression: Bug 31813 incorrectly affected labels in the header search This patch adds a specific white-space property to header search labels so that they do not wrap. The change made by Bug 31813 overrode the white-space property incorrectly. To test, apply the patch and rebuild the staff interface CSS. - Go to Administration. - The header search label "Search system preferences" should appear on one line. - Check that labels still wrap correctly on pages like the patron edit screen and the staged MARC record detail view. https://bugs.koha-community.org/show_bug.cgi?id=31794 Signed-off-by: David Nind <david@davidnind.com>
Returning to ASSIGNED while I look at some other issues.
Created attachment 142717 [details] [review] Bug 31974: Regression: Bug 31813 incorrectly affected labels in the header search This patch adds a specific white-space property to header search labels so that they do not wrap. The change made by Bug 31813 overrode the white-space property incorrectly. To test, apply the patch and rebuild the staff interface CSS. - Go to Administration. - The header search label "Search system preferences" should appear on one line. - Check that labels still wrap correctly on pages like the patron edit screen and the staged MARC record detail view. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 142718 [details] [review] Bug 31974: (follow-up) Correct some other specificity issues This follow-up makes a couple other minor corrections to label alignment. This allows for correct top-alignment of labels in forms but lets labels in other contexts, especially checkbox or radio button labels, to be aligned "middle."
Created attachment 142787 [details] [review] Bug 31974: (follow-up) Correct some other specificity issues This follow-up makes a couple other minor corrections to label alignment. This allows for correct top-alignment of labels in forms but lets labels in other contexts, especially checkbox or radio button labels, to be aligned "middle." Signed-off-by: David Nind <david@davidnind.com>
Testing notes (using koha-testing-docker): - For the second patch, look at the alignment of the label/checkboxes when checking out for: . Remember for session . Automatic renewal . Forgive fines on return (in the checkouts table) - Also can see on the check in form when the options are expanded: . Remember return date for next check in . Book drop mode
Very happy to see this fixed, I found it kinda upsetting :)
Created attachment 142812 [details] [review] Bug 31974: Regression: Bug 31813 incorrectly affected labels in the header search This patch adds a specific white-space property to header search labels so that they do not wrap. The change made by Bug 31813 overrode the white-space property incorrectly. To test, apply the patch and rebuild the staff interface CSS. - Go to Administration. - The header search label "Search system preferences" should appear on one line. - Check that labels still wrap correctly on pages like the patron edit screen and the staged MARC record detail view. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 142813 [details] [review] Bug 31974: (follow-up) Correct some other specificity issues This follow-up makes a couple other minor corrections to label alignment. This allows for correct top-alignment of labels in forms but lets labels in other contexts, especially checkbox or radio button labels, to be aligned "middle." Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
*** Bug 32047 has been marked as a duplicate of this bug. ***
Pushed to master for 22.11. Nice work everyone, thanks!