Bug 31974 - Regression: Bug 31813 incorrectly affected labels in the header search
Summary: Regression: Bug 31813 incorrectly affected labels in the header search
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
: 32047 (view as bug list)
Depends on: 30952 31813
Blocks:
  Show dependency treegraph
 
Reported: 2022-10-25 16:08 UTC by Owen Leonard
Modified: 2023-12-28 20:42 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31974: Regression: Bug 31813 incorrectly affected labels in the header search (1.28 KB, patch)
2022-10-25 16:23 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31974: Regression: Bug 31813 incorrectly affected labels in the header search (1.33 KB, patch)
2022-10-25 20:04 UTC, David Nind
Details | Diff | Splinter Review
Bug 31974: Regression: Bug 31813 incorrectly affected labels in the header search (1.28 KB, patch)
2022-10-27 14:41 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31974: (follow-up) Correct some other specificity issues (1.29 KB, patch)
2022-10-27 14:41 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31974: (follow-up) Correct some other specificity issues (1.33 KB, patch)
2022-10-28 19:50 UTC, David Nind
Details | Diff | Splinter Review
Bug 31974: Regression: Bug 31813 incorrectly affected labels in the header search (1.33 KB, patch)
2022-10-30 10:03 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31974: (follow-up) Correct some other specificity issues (1.39 KB, patch)
2022-10-30 10:03 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2022-10-25 16:08:32 UTC
The CSS change Bug 31813 resulted in the white-space property of header search labels being overridden. We need to make sure the header search labels do not wrap.
Comment 1 Owen Leonard 2022-10-25 16:23:35 UTC Comment hidden (obsolete)
Comment 2 David Nind 2022-10-25 20:04:48 UTC
Created attachment 142654 [details] [review]
Bug 31974: Regression: Bug 31813 incorrectly affected labels in the header search

This patch adds a specific white-space property to header search labels
so that they do not wrap. The change made by Bug 31813 overrode the
white-space property incorrectly.

To test, apply the patch and rebuild the staff interface CSS.

- Go to Administration.
- The header search label "Search system preferences" should appear on
  one line.
- Check that labels still wrap correctly on pages like the patron edit
  screen and the staged MARC record detail view.

https://bugs.koha-community.org/show_bug.cgi?id=31794

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Owen Leonard 2022-10-26 18:42:01 UTC
Returning to ASSIGNED while I look at some other issues.
Comment 4 Owen Leonard 2022-10-27 14:41:28 UTC
Created attachment 142717 [details] [review]
Bug 31974: Regression: Bug 31813 incorrectly affected labels in the header search

This patch adds a specific white-space property to header search labels
so that they do not wrap. The change made by Bug 31813 overrode the
white-space property incorrectly.

To test, apply the patch and rebuild the staff interface CSS.

- Go to Administration.
- The header search label "Search system preferences" should appear on
  one line.
- Check that labels still wrap correctly on pages like the patron edit
  screen and the staged MARC record detail view.

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Owen Leonard 2022-10-27 14:41:32 UTC
Created attachment 142718 [details] [review]
Bug 31974: (follow-up) Correct some other specificity issues

This follow-up makes a couple other minor corrections to label
alignment. This allows for correct top-alignment of labels in forms but
lets labels in other contexts, especially checkbox or radio button
labels, to be aligned "middle."
Comment 6 David Nind 2022-10-28 19:50:19 UTC
Created attachment 142787 [details] [review]
Bug 31974: (follow-up) Correct some other specificity issues

This follow-up makes a couple other minor corrections to label
alignment. This allows for correct top-alignment of labels in forms but
lets labels in other contexts, especially checkbox or radio button
labels, to be aligned "middle."

Signed-off-by: David Nind <david@davidnind.com>
Comment 7 David Nind 2022-10-28 19:57:22 UTC
Testing notes (using koha-testing-docker):

- For the second patch, look at the alignment of the label/checkboxes when checking out for:
  . Remember for session
  . Automatic renewal
  . Forgive fines on return (in the checkouts table)
- Also can see on the check in form when the options are expanded:
  . Remember return date for next check in
  . Book drop mode
Comment 8 Katrin Fischer 2022-10-30 10:01:50 UTC
Very happy to see this fixed, I found it kinda upsetting :)
Comment 9 Katrin Fischer 2022-10-30 10:03:20 UTC
Created attachment 142812 [details] [review]
Bug 31974: Regression: Bug 31813 incorrectly affected labels in the header search

This patch adds a specific white-space property to header search labels
so that they do not wrap. The change made by Bug 31813 overrode the
white-space property incorrectly.

To test, apply the patch and rebuild the staff interface CSS.

- Go to Administration.
- The header search label "Search system preferences" should appear on
  one line.
- Check that labels still wrap correctly on pages like the patron edit
  screen and the staged MARC record detail view.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 10 Katrin Fischer 2022-10-30 10:03:25 UTC
Created attachment 142813 [details] [review]
Bug 31974: (follow-up) Correct some other specificity issues

This follow-up makes a couple other minor corrections to label
alignment. This allows for correct top-alignment of labels in forms but
lets labels in other contexts, especially checkbox or radio button
labels, to be aligned "middle."

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 11 Owen Leonard 2022-10-31 14:44:27 UTC
*** Bug 32047 has been marked as a duplicate of this bug. ***
Comment 12 Tomás Cohen Arazi 2022-11-03 12:56:00 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!