When first accessing the authorized values page, the breadcrumbs say that we are in the AR_CANCELLATION category. To test: 1. Go to Administration > Authorized values --> Breadcrumbs indicate Home / Administration / Authorized values / Authorized values for category AR_CANCELLATION
This bug goes back to at least 22.05. I checked 21.05 and that version is fine. Not sure for 21.11...
This isn't a template problem, it's a problem with the way the interface behaves in the absence of any search input. The interface use to always show the first authorized value category (alphabetically) instead of showing a table of all categories. A variable is still being passed to the template with this default category which is being picked up by the breadcrumbs. We don't need the system to pick a category in the absence of a category selection because we want it to list all.
Bug 31976: Incorrect breadcrumbs in authorised_values.tt main page
Created attachment 142676 [details] [review] Bug 31976: Incorrect default category selected by authorized values page This patch removes some obsolete code for selecting a default authorized value category to be shown when the user first arrives on the authorized values page. This has not been necessary since we switched to an interface which lists all categories. NOTE: This bug will not be reproducible if your first authorized value, alphabetically, has no values associated with it. For instance, if you delete all authorized values in the AR_CANCELLATION category. To test, apply the patch and go to Administration -> Authorized values. In the breadcrumbs menu you should see "Home -> Administration -> Authorized values." Clicking any of the authorized value categories in the list should take you to a view of that category's values.
Created attachment 142677 [details] [review] Bug 31976: Incorrect default category selected by authorized values page This patch removes some obsolete code for selecting a default authorized value category to be shown when the user first arrives on the authorized values page. This has not been necessary since we switched to an interface which lists all categories. NOTE: This bug will not be reproducible if your first authorized value, alphabetically, has no values associated with it. For instance, if you delete all authorized values in the AR_CANCELLATION category. To test, apply the patch and go to Administration -> Authorized values. In the breadcrumbs menu you should see "Home -> Administration -> Authorized values." Clicking any of the authorized value categories in the list should take you to a view of that category's values. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Created attachment 142682 [details] [review] Bug 31976: Incorrect default category selected by authorized values page This patch removes some obsolete code for selecting a default authorized value category to be shown when the user first arrives on the authorized values page. This has not been necessary since we switched to an interface which lists all categories. NOTE: This bug will not be reproducible if your first authorized value, alphabetically, has no values associated with it. For instance, if you delete all authorized values in the AR_CANCELLATION category. To test, apply the patch and go to Administration -> Authorized values. In the breadcrumbs menu you should see "Home -> Administration -> Authorized values." Clicking any of the authorized value categories in the list should take you to a view of that category's values. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 22.11. Nice work everyone, thanks!
Backported to 22.05.x for upcoming 22.05.08
applied to 21.11 for 21.11.15
Not backported to 21.05.x