This is an odd script - it looks like the intent was to have one script that could call various reports. We have a single "plugin" for the reports - itemtypes.plugin We should convert this to a regular report script
Indeed, it can be like reports/itemslost.pl
I just found this one. It's dreadful in a number of ways.
Created attachment 163182 [details] [review] Bug 31988: Remove reports/itemtypes.plugin This "plugin system" is only used for the itemtypes report. We can simply remove the reports/manager.pl script and this plugin in favor of a dedicated report. Test plan: Same behaviour expected before and after this patch
Created attachment 163277 [details] [review] Bug 31988: Remove reports/itemtypes.plugin This "plugin system" is only used for the itemtypes report. We can simply remove the reports/manager.pl script and this plugin in favor of a dedicated report. Test plan: Same behaviour expected before and after this patch Signed-off-by: David Nind <david@davidnind.com>
Testing notes (using KTD): 1. Go to Reports > Other > Catalog by item type 2. Generate the report and note the results for: - Centerville - All libraries (leave library selection blank) 3. Apply the patch 4. Repeat steps 1-2 5. The results should be the same
Created attachment 163278 [details] [review] Bug 31988: Remove reports/itemtypes.plugin This "plugin system" is only used for the itemtypes report. We can simply remove the reports/manager.pl script and this plugin in favor of a dedicated report. Test plan: Same behaviour expected before and after this patch Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org>
Created attachment 163307 [details] [review] Bug 31988: Remove reports/itemtypes.plugin This "plugin system" is only used for the itemtypes report. We can simply remove the reports/manager.pl script and this plugin in favor of a dedicated report. Test plan: Same behaviour expected before and after this patch Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
All working as expected still and cleans up nicely. Passing QA
Pushed for 24.05! Well done everyone, thank you!
Can this please be rebased for 22.05
Pushed to 23.11.x for 23.11.04
(In reply to wainuiwitikapark from comment #12) > Can this please be rebased for 22.05 Figured out the conflicts Backported for for 22.05.20