Bug 31988 - manager.pl is only user for "Catalog by item type" report
Summary: manager.pl is only user for "Catalog by item type" report
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: Main
Hardware: All All
: P5 - low major with 6 votes (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 24879
  Show dependency treegraph
 
Reported: 2022-10-26 12:49 UTC by Nick Clemens
Modified: 2024-03-27 15:06 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.04,23.05.10,22.11.16,22.05.20


Attachments
Bug 31988: Remove reports/itemtypes.plugin (11.86 KB, patch)
2024-03-15 09:16 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 31988: Remove reports/itemtypes.plugin (11.89 KB, patch)
2024-03-15 19:37 UTC, David Nind
Details | Diff | Splinter Review
Bug 31988: Remove reports/itemtypes.plugin (11.96 KB, patch)
2024-03-15 19:56 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 31988: Remove reports/itemtypes.plugin (12.03 KB, patch)
2024-03-18 11:07 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2022-10-26 12:49:43 UTC
This is an odd script - it looks like the intent was to have one script that could call various reports.

We have a single "plugin" for the reports - itemtypes.plugin

We should convert this to a regular report script
Comment 1 Fridolin Somers 2023-07-27 22:01:26 UTC
Indeed, it can be like reports/itemslost.pl
Comment 3 David Cook 2023-09-22 01:20:36 UTC
I just found this one. It's dreadful in a number of ways.
Comment 5 Jonathan Druart 2024-03-15 09:16:14 UTC
Created attachment 163182 [details] [review]
Bug 31988: Remove reports/itemtypes.plugin

This "plugin system" is only used for the itemtypes report. We can
simply remove the reports/manager.pl script and this plugin in favor of
a dedicated report.

Test plan:
Same behaviour expected before and after this patch
Comment 6 David Nind 2024-03-15 19:37:35 UTC
Created attachment 163277 [details] [review]
Bug 31988: Remove reports/itemtypes.plugin

This "plugin system" is only used for the itemtypes report. We can
simply remove the reports/manager.pl script and this plugin in favor of
a dedicated report.

Test plan:
Same behaviour expected before and after this patch

Signed-off-by: David Nind <david@davidnind.com>
Comment 7 David Nind 2024-03-15 19:41:17 UTC
Testing notes (using KTD):

1. Go to Reports > Other > Catalog by item type
2. Generate the report and note the results for:
   - Centerville
   - All libraries (leave library selection blank)
3. Apply the patch
4. Repeat steps 1-2
5. The results should be the same
Comment 8 Andrew Fuerste-Henry 2024-03-15 19:56:27 UTC
Created attachment 163278 [details] [review]
Bug 31988: Remove reports/itemtypes.plugin

This "plugin system" is only used for the itemtypes report. We can
simply remove the reports/manager.pl script and this plugin in favor of
a dedicated report.

Test plan:
Same behaviour expected before and after this patch

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org>
Comment 9 Martin Renvoize 2024-03-18 11:07:30 UTC
Created attachment 163307 [details] [review]
Bug 31988: Remove reports/itemtypes.plugin

This "plugin system" is only used for the itemtypes report. We can
simply remove the reports/manager.pl script and this plugin in favor of
a dedicated report.

Test plan:
Same behaviour expected before and after this patch

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 10 Martin Renvoize 2024-03-18 11:08:25 UTC
All working as expected still and cleans up nicely.

Passing QA
Comment 11 Katrin Fischer 2024-03-18 17:04:59 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 12 wainuiwitikapark 2024-03-20 23:24:24 UTC
Can this please be rebased for 22.05
Comment 13 Fridolin Somers 2024-03-21 09:57:58 UTC
Pushed to 23.11.x for 23.11.04
Comment 14 wainuiwitikapark 2024-03-22 00:34:28 UTC
(In reply to wainuiwitikapark from comment #12)
> Can this please be rebased for 22.05

Figured out the conflicts

Backported for for 22.05.20