Bug 32004 - Increase font size in top navigation pull downs
Summary: Increase font size in top navigation pull downs
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Martin Renvoize
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 30952
Blocks:
  Show dependency treegraph
 
Reported: 2022-10-26 21:56 UTC by Katrin Fischer
Modified: 2023-06-08 22:28 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Overlay of previous version and current version (201.66 KB, image/png)
2022-11-04 17:50 UTC, Owen Leonard
Details
Bug 32004: Match font size for dropdowns to header (777 bytes, patch)
2022-11-08 16:13 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 32004: Match font size for dropdowns to header (834 bytes, patch)
2022-11-09 12:53 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32004: Match font size for dropdowns to header (885 bytes, patch)
2022-11-09 13:51 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32004: (follow-up) Increase padding between menu items (991 bytes, patch)
2022-11-09 13:51 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-10-26 21:56:54 UTC
The script in the More and Search pull downs is really small and smaller as the entry in the navigation even. We should make them the same font size (1st an 2nd level navigation)
Comment 1 Owen Leonard 2022-11-04 17:50:46 UTC
Created attachment 143262 [details]
Overlay of previous version and current version

Overlaying the two versions it looks to me like the new version is, if anything, slightly larger.
Comment 2 Martin Renvoize 2022-11-08 16:08:13 UTC
Inspecting the page on this it appears we're setting font in px.. the top bar options are 13px and the dropdown are 12px
Comment 3 Martin Renvoize 2022-11-08 16:13:58 UTC
Created attachment 143446 [details] [review]
Bug 32004: Match font size for dropdowns to header
Comment 4 Katrin Fischer 2022-11-09 12:53:19 UTC
Created attachment 143501 [details] [review]
Bug 32004: Match font size for dropdowns to header

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Katrin Fischer 2022-11-09 12:54:12 UTC
(In reply to Owen Leonard from comment #1)
> Created attachment 143262 [details]
> Overlay of previous version and current version
> 
> Overlaying the two versions it looks to me like the new version is, if
> anything, slightly larger.

Maybe it's the different font, it just looks still all a little smaller to me than before, but I think this patch is a good improvement.
Comment 6 Owen Leonard 2022-11-09 13:51:06 UTC
Created attachment 143512 [details] [review]
Bug 32004: Match font size for dropdowns to header

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 7 Owen Leonard 2022-11-09 13:51:11 UTC
Created attachment 143513 [details] [review]
Bug 32004: (follow-up) Increase padding between menu items

I think the increased font size means we need slightly more padding
between items for good legibility.
Comment 8 Katrin Fischer 2022-11-09 13:51:53 UTC
Thx, Owen!
Comment 9 Martin Renvoize 2022-11-09 13:53:29 UTC
Thanks Owen :)
Comment 10 Tomás Cohen Arazi 2022-11-09 17:40:07 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!