Bug 32005 - Spacing between entries in left side navigation on staff catalog detail page is uneven
Summary: Spacing between entries in left side navigation on staff catalog detail page ...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Martin Renvoize
QA Contact: Testopia
URL:
Keywords:
Depends on: 30952
Blocks:
  Show dependency treegraph
 
Reported: 2022-10-26 22:00 UTC by Katrin Fischer
Modified: 2023-06-08 22:28 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 32005: Remove stack unordered lists (1.49 KB, patch)
2022-11-08 16:30 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 32005: Cleanup indenting (8.23 KB, patch)
2022-11-08 16:31 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 32005: Remove stack unordered lists (1.55 KB, patch)
2022-11-10 10:19 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32005: Cleanup indenting (8.29 KB, patch)
2022-11-10 10:19 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-10-26 22:00:54 UTC
Catalog detail page in staff:

There is a wider gap between holds and checkout history than between the other entries.
It looks like we have 2 different ol listings here instead of only one.
Comment 1 Martin Renvoize 2022-11-08 16:30:56 UTC
Created attachment 143447 [details] [review]
Bug 32005: Remove stack unordered lists

Not sure why, but we had two unordered list elements stacked on top of
each other here instead of just one overall list.
Comment 2 Martin Renvoize 2022-11-08 16:31:00 UTC
Created attachment 143448 [details] [review]
Bug 32005: Cleanup indenting
Comment 3 Katrin Fischer 2022-11-10 10:19:00 UTC
Created attachment 143634 [details] [review]
Bug 32005: Remove stack unordered lists

Not sure why, but we had two unordered list elements stacked on top of
each other here instead of just one overall list.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Katrin Fischer 2022-11-10 10:19:04 UTC
Created attachment 143635 [details] [review]
Bug 32005: Cleanup indenting

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Katrin Fischer 2022-11-10 10:19:40 UTC
The indenting patch could in theory affect translations (not sure how much change is needed to trigger a fuzzy)
Comment 6 Tomás Cohen Arazi 2022-11-10 13:06:33 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!