Created attachment 142807 [details] Screenshot of circulation alert When you work on a smaller screen or with a smaller window, the circulation alerts like in the screenshot can overlap with the other elements a bit. Also: When the element is active, we see a red border and round corners.
Created attachment 143259 [details] [review] Bug 32043: Circulation alerts can overlap other elements on smaller screens This patch makes a minor change to CSS controlling the appearance of the dialog which appears on the checkout page when a confirmation is required. To test, apply the patch and rebuild the staff interface CSS. Open a patron account for checkout, and submit the barcode of an item which will require confirmation before the operation can be completed. For example: - Item on hold for another patron - Item waiting for another patron - Item is checked out to another patron. The confirmation dialog should have a comfortable margin between it and the checkout form.
Created attachment 143291 [details] [review] Bug 32043: Circulation alerts can overlap other elements on smaller screens This patch makes a minor change to CSS controlling the appearance of the dialog which appears on the checkout page when a confirmation is required. To test, apply the patch and rebuild the staff interface CSS. Open a patron account for checkout, and submit the barcode of an item which will require confirmation before the operation can be completed. For example: - Item on hold for another patron - Item waiting for another patron - Item is checked out to another patron. The confirmation dialog should have a comfortable margin between it and the checkout form. Signed-off-by: David Nind <david@davidnind.com>
Testing notes: - This was happening to me even on a large monitor (27") with browser window maximised. - Another occurrence to test is if you checkout an item to a patron and set the due date in the past.
Created attachment 143599 [details] [review] Bug 32043: Circulation alerts can overlap other elements on smaller screens This patch makes a minor change to CSS controlling the appearance of the dialog which appears on the checkout page when a confirmation is required. To test, apply the patch and rebuild the staff interface CSS. Open a patron account for checkout, and submit the barcode of an item which will require confirmation before the operation can be completed. For example: - Item on hold for another patron - Item waiting for another patron - Item is checked out to another patron. The confirmation dialog should have a comfortable margin between it and the checkout form. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 22.11. Nice work everyone, thanks!