Bug 32073 - Consistent classes for primary buttons: Circulation
Summary: Consistent classes for primary buttons: Circulation
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 32067
  Show dependency treegraph
 
Reported: 2022-11-02 12:38 UTC by Owen Leonard
Modified: 2023-06-08 22:28 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 32073: Consistent classes for primary buttons: Circulation (16.41 KB, patch)
2022-11-02 12:46 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32073: Consistent classes for primary buttons: Circulation (16.47 KB, patch)
2022-11-10 15:46 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32073: (QA follow-up) Fix capitalization: Cancel and Transfer all (1.37 KB, patch)
2022-11-10 15:46 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2022-11-02 12:38:20 UTC
As part of Bug 32067 - [OMNIBUS] Consistent classes for submit and/or primary buttons:

This patch will update buttons in circulation templates so that buttons which are currently styled as primary buttons will have the the "btn btn-primary" classes.

In some places, the classes have been added to buttons which were not input[type='submit'] but which should be styled as primary.
Comment 1 Owen Leonard 2022-11-02 12:46:44 UTC
Created attachment 142952 [details] [review]
Bug 32073: Consistent classes for primary buttons: Circulation

This patch makes changes the button markup in Circulation templates --
including offline circulation -- so that all submit buttons and any
buttons that should should be styled as primary buttons have the
Bootstrap class "btn btn-primary."

To test, apply the patch and view pages in Circulation to confirm
that everything looks correct. In most cases there are no visible
changes.
Comment 2 Katrin Fischer 2022-11-10 15:41:39 UTC
looking here...
Comment 3 Katrin Fischer 2022-11-10 15:46:32 UTC
Created attachment 143678 [details] [review]
Bug 32073: Consistent classes for primary buttons: Circulation

This patch makes changes the button markup in Circulation templates --
including offline circulation -- so that all submit buttons and any
buttons that should should be styled as primary buttons have the
Bootstrap class "btn btn-primary."

To test, apply the patch and view pages in Circulation to confirm
that everything looks correct. In most cases there are no visible
changes.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Katrin Fischer 2022-11-10 15:46:36 UTC
Created attachment 143679 [details] [review]
Bug 32073: (QA follow-up) Fix capitalization: Cancel and Transfer all

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Katrin Fischer 2022-11-10 15:47:01 UTC
Going straight to PQA for this one (string fix included).
Comment 6 Tomás Cohen Arazi 2022-11-10 17:51:39 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!