The logic used in build_holds_queue is all based on the item location and the patron's home branch, on the assumption that the patron will be picking the hold up at their home branch. That's going to be correct often, but not always. We should instead look at the hold pickup location, reserves.branchcode.
That sounds like a pretty big oversight to the general holds system?
Is there a way to test this/make it visible in the GUI?
(In reply to Katrin Fischer from comment #1)
> That sounds like a pretty big oversight to the general holds system?
> Is there a way to test this/make it visible in the GUI?
I think it's basically taking bug 31557 and adding a third option, pickup branch. Does that summarize this correctly Andrew?
I'm actually closing this one.
In talking through bug 31557, we misread the code a bit. I've just run through some scenarios that should have led to some weird hold targeting if our read was correct, but Koha consistently picked the item at the hold pickup location rather than the patron's branch, so this appears to be working as desired.
Clearly I'm just too ready to think the worst of the holds system. False alarm!
Thx for testing, Andrew!