Bug 32094 - Consistent classes for primary buttons: Serials
Summary: Consistent classes for primary buttons: Serials
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords: rel_22_11_candidate
Depends on:
Blocks: 32067
  Show dependency treegraph
 
Reported: 2022-11-03 14:34 UTC by Owen Leonard
Modified: 2023-06-08 22:28 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 32094: Consistent classes for primary buttons: Serials (15.04 KB, patch)
2022-11-03 14:42 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32094: Consistent classes for primary buttons: Serials (15.10 KB, patch)
2022-11-10 22:40 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32094: Consistent classes for primary buttons: Serials (15.18 KB, patch)
2022-11-14 12:32 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2022-11-03 14:34:26 UTC
As part of Bug 32067 - [OMNIBUS] Consistent classes for submit and/or primary buttons:

This patch will update buttons in serials templates so that buttons which are currently styled as primary buttons will have the the "btn btn-primary" classes.

In some places, the classes have been added to buttons which were not input[type='submit'] but which should be styled as primary.
Comment 1 Owen Leonard 2022-11-03 14:42:51 UTC
Created attachment 143121 [details] [review]
Bug 32094: Consistent classes for primary buttons: Serials

This patch makes changes the button markup in serials templates so that
all submit buttons and any buttons that should should be styled as
primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view serials pages to confirm that
everything looks correct. In most cases there are no visible
changes.
Comment 2 Katrin Fischer 2022-11-10 22:40:13 UTC
Created attachment 143733 [details] [review]
Bug 32094: Consistent classes for primary buttons: Serials

This patch makes changes the button markup in serials templates so that
all submit buttons and any buttons that should should be styled as
primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view serials pages to confirm that
everything looks correct. In most cases there are no visible
changes.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 3 Tomás Cohen Arazi 2022-11-14 12:32:02 UTC
Created attachment 143824 [details] [review]
Bug 32094: Consistent classes for primary buttons: Serials

This patch makes changes the button markup in serials templates so that
all submit buttons and any buttons that should should be styled as
primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view serials pages to confirm that
everything looks correct. In most cases there are no visible
changes.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 4 Tomás Cohen Arazi 2022-11-14 12:40:55 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!