Bug 32108 - Change "x" icon to replace patron when scheduling a pickup
Summary: Change "x" icon to replace patron when scheduling a pickup
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 30650
Blocks:
  Show dependency treegraph
 
Reported: 2022-11-04 11:22 UTC by Jonathan Druart
Modified: 2023-06-08 22:29 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 32108: Replace "x" icon with "trash" + Remove (1.53 KB, patch)
2022-11-04 11:27 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32108: Replace "x" icon with "trash" + Remove (1.58 KB, patch)
2022-11-04 12:16 UTC, David Nind
Details | Diff | Splinter Review
[ALTERNATIVE PATCH] Bug 32108: Replace "x" icon with the "search" icon (1.53 KB, patch)
2022-11-07 12:22 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32108: Replace "x" icon with the "search" icon (1.58 KB, patch)
2022-11-10 00:54 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2022-11-04 11:22:48 UTC
It's now a green 'x' icon, we should use the trash icon + "Remove", like in other areas of Koha (add/remove guarantor for instance).
Comment 1 Jonathan Druart 2022-11-04 11:27:58 UTC
Created attachment 143176 [details] [review]
Bug 32108: Replace "x" icon with "trash" + Remove

Change "x" icon to replace patron when scheduling a pickup.

Test plan:
Schedule a new pickup, select a patron, notice the change.
Comment 2 David Nind 2022-11-04 12:16:00 UTC
Created attachment 143180 [details] [review]
Bug 32108: Replace "x" icon with "trash" + Remove

Change "x" icon to replace patron when scheduling a pickup.

Test plan:
Schedule a new pickup, select a patron, notice the change.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2022-11-04 12:29:19 UTC
Testing notes (using koha-testing-docker).

Since I haven't used the curbside pick up before, these are my notes on setting things up for testing:
1. Enable the CurbsidePickup system preference.
2. Setup dates and times when pickups are available;
   2.1 Go to Administration > Patrons and circulation > Curbside pickup
   2.2 For a library (for example Centerville) click on enable, pickup interval = 5, maximum patrons per interval = 2, enable for waiting holds only, and add some slots, and save.
3. Place some holds for a patron for pickup at the library enabled.
4. Check items in and fulfil the holds.
5. Schedule a pcikup time for the patron:
   5.1 Go to Circulation > Holds > Curbside pickups.
   5.2 Select the schedule pickup tab.
   5.3 Start typing the patron's name and select.
6. Next to the patron name is a red X before the patch.
7. Apply the patch and refresh the page.
8. The red X is replaced with a green trash can and Remove.
Comment 4 Katrin Fischer 2022-11-06 09:48:36 UTC
I like the x icon better than the trash icon, because it does empty the field but not actually delete/remove. I think the red color was restored by another patch I tested, but not sure which one right now :(
Comment 5 Jonathan Druart 2022-11-07 12:06:01 UTC
(In reply to Katrin Fischer from comment #4)
> I like the x icon better than the trash icon, because it does empty the
> field but not actually delete/remove. I think the red color was restored by
> another patch I tested, but not sure which one right now :(

As said in the commit message I have simply copied the behaviour from other areas (like the guarantor when editing a patron).
Shouldn't we reach consistency first, then improve if we want it?
Comment 6 Jonathan Druart 2022-11-07 12:20:06 UTC
Should we actually have a "search" icon? The tooltip of the icon says "Search for another patron".
Comment 7 Jonathan Druart 2022-11-07 12:22:13 UTC
Created attachment 143353 [details] [review]
[ALTERNATIVE PATCH] Bug 32108: Replace "x" icon with the "search" icon

Change "x" icon to replace patron when scheduling a pickup.

Test plan:
Schedule a new pickup, select a patron, notice the change.
Comment 8 Jonathan Druart 2022-11-07 12:24:31 UTC
How it looks like with the alternative patch: https://snipboard.io/YsFVnT.jpg
Comment 9 Katrin Fischer 2022-11-07 12:52:38 UTC
(In reply to Jonathan Druart from comment #8)
> How it looks like with the alternative patch: https://snipboard.io/YsFVnT.jpg

Sorry, I think I was too much in a hurry here - I thought you wanted to replace the X in general. But: I really like the change to the search icon.
Comment 10 Katrin Fischer 2022-11-10 00:53:58 UTC
Is it expected that the search doesn't work with cardnumber? Or is it because 42 is too short an input?
Comment 11 Katrin Fischer 2022-11-10 00:54:40 UTC
Created attachment 143611 [details] [review]
Bug 32108: Replace "x" icon with the "search" icon

Change "x" icon to replace patron when scheduling a pickup.

Test plan:
Schedule a new pickup, select a patron, notice the change.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 12 Jonathan Druart 2022-11-10 06:08:29 UTC
(In reply to Katrin Fischer from comment #10)
> Is it expected that the search doesn't work with cardnumber? Or is it
> because 42 is too short an input?

The autocomplete starts at 3 chars, yes. Is that a problem?
Comment 13 Tomás Cohen Arazi 2022-11-10 13:05:13 UTC
Is this PQA or In discussion?
Comment 14 Katrin Fischer 2022-11-10 16:18:29 UTC
(In reply to Jonathan Druart from comment #12)
> (In reply to Katrin Fischer from comment #10)
> > Is it expected that the search doesn't work with cardnumber? Or is it
> > because 42 is too short an input?
> 
> The autocomplete starts at 3 chars, yes. Is that a problem?

I think it's at least a totally different issue than the button :)
Comment 15 Katrin Fischer 2022-11-10 16:19:50 UTC
(In reply to Tomás Cohen Arazi from comment #13)
> Is this PQA or In discussion?

I feel the search icon is fine, so no disagreement on my side, we could ask for another opinion if you think it would be better.
Comment 16 Tomás Cohen Arazi 2022-11-10 17:51:44 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!